New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue performance warning if chromeFlags includes --headless #2675

Closed
paulirish opened this Issue Jul 11, 2017 · 6 comments

Comments

Projects
None yet
6 participants
@paulirish
Member

paulirish commented Jul 11, 2017

Headless doesn't support network throttling, so performance measurements aren't comparable against regular headful chrome.

I figure we can at least issue a warning to remind people of this until it's fixed in Chrome.

@ebidel

This comment has been minimized.

Member

ebidel commented Dec 8, 2017

@paulirish I think this is finally fixed :)

@paulirish paulirish closed this Dec 9, 2017

@ataylorme

This comment has been minimized.

ataylorme commented Dec 11, 2017

@ebidel to clarify the warning has been added to Lighthouse, not network throttling support with headless Chrome, correct? I saw the Chrome bug was marked fixed so thought it's worth asking.

@ebidel

This comment has been minimized.

Member

ebidel commented Dec 11, 2017

We did some testing on Friday. Turns out headless chrome now supports network throttling! It wasn't 100% clear from that bug.

Headless supports throttling as of Chrome 63. We're updating the warning to only complain when you use headless on an older version. See #4021.

@ataylorme

This comment has been minimized.

ataylorme commented Dec 11, 2017

@ebidel this is great news! I tested this out and ran headless Chrome 63 with Lighthouse and saw the same scores as running with the browser extension. Have this running as part of my CI process now!

@smanwaring

This comment has been minimized.

smanwaring commented May 3, 2018

@ataylorme Curious how you were able to specify a Chrome version for your CI? Running into the same issues on my end.

@ataylorme

This comment has been minimized.

ataylorme commented May 3, 2018

I just used the latest stable version of Chrome. At the time I built my Docker image that was 63. You can check out the image here.

This is a good reminder to update my Lighthouse version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment