Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch deprecations audit from ChromeConsoleMessages => ReportingObserver #5707

Open
ebidel opened this issue Jul 23, 2018 · 1 comment

Comments

@ebidel
Copy link
Contributor

commented Jul 23, 2018

The current impl uses the ChromeConsoleMessages gatherer and filters on message.type === 'deprecation'.

This works great, but ReportingObserver provides a better structured API intended for observing deprecations. It has other nice feature like buffering (can include deprecations that happen before the observer was added to the page) useful fields like anticipatedRemoval:

screen shot 2018-07-23 at 9 53 29 am

Switching to a ReportingObserver-based would set us up nicely for future audits that use the Reporting API: CSP violations, feature policy violations, browser interventions.

@brendankenny

This comment has been minimized.

Copy link
Member

commented Jul 24, 2018

Ideally we could do this through the protocol as inserting observers into the host page has a host of problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.