Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
"Site does not register a service worker." While it does #6342
Provide the steps to reproduce
What is the current behavior?
If you uncheck
What is the expected behavior?
The audit should not say
(and thanks for you awesome work!)
In general it's recommended to only include essential (small) resources into service worker, like .js, .css, .html files to make the app work at all. Seek for other caching opportunities for large media files like images or videos.
Thanks for taking a look, can you explain me where did you see the 22.8MB download ?
Here I see around 2MB being downloaded: http://www.webpagetest.org/result/181024_X8_a38dbdaa3f958476f9dd6eed796f8f9e/
LH seems to agree :
More details about the page:
referenced this issue
Feb 22, 2019
Hello, I was experiencing this as well (chrome 72.0.3626.119) today.
However, I was precaching quite large image files. Based on the comment of @midzer, I removed them (this is mere a test project) and gave it another try. The lighthouse scan passes and offers a score of 100 on PWA.
Note that I used Workbox from the CDN (https://storage.googleapis.com/workbox-cdn/releases/3.6.1/workbox-sw.js)