New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
If all audits in a category are not applicable
the category should be marked not applicable
#7623
Comments
Oh yeah great point @jburger424! 👍 I agree "N/A" seems like a good solution here. |
But they also didn't do anything wrong :) But, agreed, it's weird to not count notApplicable audits in the score until the last one (and we don't want to count the earlier notApplicable audits either), so SGTM!
my main concern is i18n. I'm not sure how well we can get this to translate, or if we need to think of another way (symbol?) to express this. Greyed out sounds good, though (and I believe fits into our UI harmonization effort). |
We have a consensus on the design #9803 (comment) @jburger424 do you want to take this on? |
Hi, is this issue still open to be worked on? |
@saavan-google-intern Yes, this is still open (@exterkamp to confirm this is still worth implementing). I was still planning to take this on at some point, but happy to pass the issue if you wanted to take it over as it isn't something I'll be able to do right now. |
@saavan-google-intern feel free to grab this, thanks! |
@jburger424 thanks! I'll try it out. |
@connorjclark Looks like this was resolved with #11024? |
Resolved in #11024 |
Feature request summary
Currently, if n - 1 audits in a category are marked
not applicable
, the category score is based on the one applicable audit. If n audits are markednot applicable
then the category has a score of 0. This feels like the wrong behavior to me, as the site is not necessarily doing anything incorrectly.One option could be to set a category score as 100 if no audits are applicable, but this also feels wrong as the website is not necessarily doing anything correctly either in this case.
I propose that in this situation we simply display 'N/A' as the category score with a grey circle.
I'd be happy to implement this myself.
What is the motivation or use case for changing this?
While I'm unaware of any cases where this would happen with current core categories, I think it is very applicable to plugins. This would specifically be true in the case of mistakenly scanning a site using a plugin for a specific technology, when that technology is not being used on the site.
CC: @brendankenny
The text was updated successfully, but these errors were encountered: