Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHROME_INTERSTITIAL_ERROR throws on iframes #9562

Closed
benschwarz opened this issue Aug 15, 2019 · 4 comments · Fixed by #9576

Comments

@benschwarz
Copy link
Contributor

commented Aug 15, 2019

Provide the steps to reproduce

  1. Run LH on https://lh-iframe-interstitial.glitch.me/

What is the current behavior?

Lighthouse throws CHROME_INTERSTITIAL_ERROR

What is the expected behavior?

A successful test

Environment Information

  • Affected Channels: All
  • Lighthouse version: 5.2.0 (works in 5.1.0)
  • Node.js version: 11.15.0
  • Operating System: Mac OSX, Linux

I ran lighthouse with ndb to get a deeper look in:

In gather-runner.js, #getInterstitialError:

const interstitialRequest = networkRecords.find(record => record.documentURL.startsWith('chrome-error://'))

Returns a single network record, which appears to be a base64 encoded image of the chrome dino error states.

image

image

@patrickhulce

This comment has been minimized.

Copy link
Collaborator

commented Aug 15, 2019

Thanks @benschwarz! I'm not able to reproduce this locally or with PSI though. Do you know if this page is employing geo-based content differentiation?

@benschwarz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

@patrickhulce Not sure about geo-based content differentiation, but I did notice that we did not see the interstitial error when adblocking was turned on.

I think there's an ad/third party somewhere in there that throws one of the chrome-errors that's then identified in the network records. Does that sound plausible?

@benschwarz

This comment has been minimized.

Copy link
Contributor Author

commented Aug 16, 2019

I was able to reproduce this every time. I could share the trace information from --gather-mode if that's useful for re-pro?

@patrickhulce patrickhulce changed the title CHROME_INTERSTITIAL_ERROR being thrown CHROME_INTERSTITIAL_ERROR throws on iframes Aug 16, 2019

@patrickhulce

This comment has been minimized.

Copy link
Collaborator

commented Aug 16, 2019

No worries I made my own :) https://lh-iframe-interstitial.glitch.me/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.