tests: use latest windows image on appveyor #11083
Conversation
This comment has been minimized.
This comment has been minimized.
| @@ -12,6 +12,7 @@ | |||
| const expectations = [ | |||
| { | |||
| artifacts: { | |||
| HostUserAgent: /Chrome\/83/, | |||
There was a problem hiding this comment.
will delete if it passes in appveyor
There was a problem hiding this comment.
Ok, the HostUserAgent passed the test, so looks like this is working. https://ci.appveyor.com/project/paulirish/lighthouse/builds/34028162#L481
|
WDYT @connorjclark? Seems fine to run stable Chrome on AppVeyor now that we have the ToT Github actions. |
|
(and since we were apparently not running ToT Chrome on AppVeyor for a long time now anyways :) |
There was a problem hiding this comment.
a few (unexpected?) errors but newer chrome + unblocking #10976 + appveyor is on its last legs (just waiting for someone to expand GH actions to windows) = ✅
This comment has been minimized.
This comment has been minimized.
Yeah
should not be a thing that's happening... |
Fixes AppVeyor being stuck on Chrome 79 (hopefully).
AppVeyor has multiple Windows images, and most of them (including the default) are currently stuck on Chrome 79. That seems like it can't be coincidence for the issues seen in PRs like #10976, so I assume something is breaking between downloading Chrome and chrome-launcher, and the default Chrome is being used regardless of what we try to use.
So let's just update to the latest Windows image and continue to use the default :)