clients: convert devtools and lightrider entries to ES modules #13722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
17 tasks
connorjclark
commented
Mar 5, 2022
| mobile: require('../../lighthouse-core/config/lr-mobile-config.js'), | ||
| desktop: require('../../lighthouse-core/config/lr-desktop-config.js'), | ||
| mobile: mobileConfig, | ||
| desktop: desktopConfig, | ||
| }; | ||
|
|
||
| /** @typedef {import('../../lighthouse-core/gather/connections/connection.js')} Connection */ | ||
|
|
||
| // Rollup seems to overlook some references to `Buffer`, so it must be made explicit. | ||
| // (`parseSourceMapFromDataUrl` breaks without this) |
There was a problem hiding this comment.
Just realized there is no smoke test for this. Will add one monday.
adamraine
approved these changes
Mar 7, 2022
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #12689
manually confirmed to work in LR.