diff --git a/lighthouse-core/test/audits/third-party-summary-test.js b/lighthouse-core/test/audits/third-party-summary-test.js index 42183b95ff84..6cdbc517e838 100644 --- a/lighthouse-core/test/audits/third-party-summary-test.js +++ b/lighthouse-core/test/audits/third-party-summary-test.js @@ -53,7 +53,7 @@ describe('Third party summary', () => { entity: { text: 'Google Analytics', type: 'link', - url: 'https://www.google.com/analytics/analytics/', + url: 'https://marketingplatform.google.com/about/analytics/', }, mainThreadTime: 95.15599999999999, blockingTime: 0, diff --git a/lighthouse-core/test/fixtures/fraggle-rock/reports/sample-flow-result.json b/lighthouse-core/test/fixtures/fraggle-rock/reports/sample-flow-result.json index 3b57ca8d6fe0..10804549238f 100644 --- a/lighthouse-core/test/fixtures/fraggle-rock/reports/sample-flow-result.json +++ b/lighthouse-core/test/fixtures/fraggle-rock/reports/sample-flow-result.json @@ -8402,8 +8402,61 @@ "id": "third-party-summary", "title": "Minimize third-party usage", "description": "Third-party code can significantly impact load performance. Limit the number of redundant third-party providers and try to load third-party code after your page has primarily finished loading. [Learn more](https://developers.google.com/web/fundamentals/performance/optimizing-content-efficiency/loading-third-party-javascript/).", - "score": null, - "scoreDisplayMode": "notApplicable" + "score": 1, + "scoreDisplayMode": "binary", + "displayValue": "Third-party code blocked the main thread for 0 ms", + "details": { + "type": "table", + "headings": [ + { + "key": "entity", + "itemType": "link", + "text": "Third-Party", + "subItemsHeading": { + "key": "url", + "itemType": "url" + } + }, + { + "key": "transferSize", + "granularity": 1, + "itemType": "bytes", + "text": "Transfer Size", + "subItemsHeading": { + "key": "transferSize" + } + }, + { + "key": "blockingTime", + "granularity": 1, + "itemType": "ms", + "text": "Main-Thread Blocking Time", + "subItemsHeading": { + "key": "blockingTime" + } + } + ], + "items": [ + { + "mainThreadTime": 0, + "blockingTime": 0, + "transferSize": 3888, + "entity": { + "type": "link", + "text": "Algolia", + "url": "https://www.algolia.com/" + }, + "subItems": { + "type": "subitems", + "items": [] + } + } + ], + "summary": { + "wastedBytes": 3888, + "wastedMs": 0 + } + } }, "layout-shift-elements": { "id": "layout-shift-elements", @@ -10105,6 +10158,7 @@ ], "lighthouse-core/lib/i18n/i18n.js | columnTransferSize": [ "audits[resource-summary].details.headings[2].text", + "audits[third-party-summary].details.headings[1].text", "audits[uses-long-cache-ttl].details.headings[2].text", "audits[total-byte-weight].details.headings[1].text" ], @@ -10141,6 +10195,20 @@ "lighthouse-core/audits/third-party-summary.js | description": [ "audits[third-party-summary].description" ], + "lighthouse-core/audits/third-party-summary.js | displayValue": [ + { + "values": { + "timeInMs": 0 + }, + "path": "audits[third-party-summary].displayValue" + } + ], + "lighthouse-core/audits/third-party-summary.js | columnThirdParty": [ + "audits[third-party-summary].details.headings[0].text" + ], + "lighthouse-core/lib/i18n/i18n.js | columnBlockingTime": [ + "audits[third-party-summary].details.headings[2].text" + ], "lighthouse-core/audits/layout-shift-elements.js | title": [ "audits[layout-shift-elements].title" ], diff --git a/package.json b/package.json index 3d10347a5a06..f0ea12e64bd1 100644 --- a/package.json +++ b/package.json @@ -203,7 +203,7 @@ "robots-parser": "^3.0.0", "semver": "^5.3.0", "speedline-core": "^1.4.3", - "third-party-web": "^0.12.7", + "third-party-web": "^0.15.0", "ws": "^7.0.0", "yargs": "^17.3.1", "yargs-parser": "^21.0.0" diff --git a/yarn.lock b/yarn.lock index 7966fd38a220..0af39444f841 100644 --- a/yarn.lock +++ b/yarn.lock @@ -7545,10 +7545,10 @@ text-table@^0.2.0: resolved "https://registry.yarnpkg.com/text-table/-/text-table-0.2.0.tgz#7f5ee823ae805207c00af2df4a84ec3fcfa570b4" integrity sha1-f17oI66AUgfACvLfSoTsP8+lcLQ= -third-party-web@^0.12.7: - version "0.12.7" - resolved "https://registry.yarnpkg.com/third-party-web/-/third-party-web-0.12.7.tgz#64445702379abf1a29066d636a965173e4e423c6" - integrity sha512-9d/OfjEOjyeOpnm4F9o0KSK6BI6ytvi9DINSB5h1+jdlCvQlhKpViMSxWpBN9WstdfDQ61BS6NxWqcPCuQCAJg== +third-party-web@^0.15.0: + version "0.15.0" + resolved "https://registry.yarnpkg.com/third-party-web/-/third-party-web-0.15.0.tgz#40790a6394233ecf1d0b8095abde3bfadde67338" + integrity sha512-kv+TVeppmasvDBXHfKCuQ4HNXapsyEXAGVANguzVDJ98xXm88ggtb9B09rVWvwDqapU5VZ4Q4JkCu2viyD/k0w== throat@^6.0.1: version "6.0.1"