core: rename url-shim to url-utils, stop extending global URL #14360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamraine
reviewed
Sep 6, 2022
connorjclark
commented
Sep 6, 2022
| import {Util} from '../util.cjs'; | ||
| import {LighthouseError} from '../lib/lh-error.js'; | ||
| import {LighthouseError} from './lh-error.js'; |
There was a problem hiding this comment.
lol i didn't make this change, I guess vscode did some house cleaning during the File Rename refactor.
connorjclark
changed the title
adamraine
approved these changes
Sep 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #14353 (comment)
Since URL is now a Node global, we don't have to import it from our utility class to use it anywhere. Removing
extends URLfromurl-shimand changing the fews places wherenew URL(aka our "shim") was being called was straight forward. The rest of the changes here are dropping some imports (files that only need the globalURL) and renames (it's not a shim any more so....UrlUtilsseems fine as a name?)