Fix screenshot capture. #1839
Merged
Fix screenshot capture. #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the past few weeks (and potentially longer..*) the screenshots we've grabbed during a trace have looked like this:
It appears this regressed during some headless screenshot work. Both webpagetest and calibre also noticed this within the last 15 days.
The fix is fairly straightforward, though not intuitive unless you sit next to the engineers who know. Luckily i do. phew. :)
Emulation.setVisibleSizeto the rescue!Also on the bright side, Perceptual Speed Index don't appear to have been significantly affected by this regression. Because its a good metric. :)