From 2b2b821957e1d79334a9b6d28fbe8b5a0914cab7 Mon Sep 17 00:00:00 2001 From: Tim Kadlec Date: Mon, 8 Jan 2018 10:38:48 -0600 Subject: [PATCH] Update vulnerability links --- lighthouse-core/audits/dobetterweb/no-vulnerable-libraries.js | 2 +- .../test/audits/dobetterweb/no-vulnerable-libraries-test.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lighthouse-core/audits/dobetterweb/no-vulnerable-libraries.js b/lighthouse-core/audits/dobetterweb/no-vulnerable-libraries.js index 8dc036abcf53..2a8070fd4bc8 100644 --- a/lighthouse-core/audits/dobetterweb/no-vulnerable-libraries.js +++ b/lighthouse-core/audits/dobetterweb/no-vulnerable-libraries.js @@ -91,7 +91,7 @@ class NoVulnerableLibrariesAudit extends Audit { return vulns; } - lib.pkgLink = `https://snyk.io/vuln/npm:${lib.npmPkgName}#lh@${lib.version}`; + lib.pkgLink = `https://snyk.io/vuln/npm:${lib.npmPkgName}?lh@${lib.version}`; const snykInfo = snykDB.npm[lib.npmPkgName]; snykInfo.forEach(vuln => { if (semver.satisfies(lib.version, vuln.semver.vulnerable[0])) { diff --git a/lighthouse-core/test/audits/dobetterweb/no-vulnerable-libraries-test.js b/lighthouse-core/test/audits/dobetterweb/no-vulnerable-libraries-test.js index 45cf0b5191ef..0e7d60d594d3 100644 --- a/lighthouse-core/test/audits/dobetterweb/no-vulnerable-libraries-test.js +++ b/lighthouse-core/test/audits/dobetterweb/no-vulnerable-libraries-test.js @@ -39,7 +39,7 @@ describe('Avoids front-end JavaScript libraries with known vulnerabilities', () assert.equal(auditResult.extendedInfo.jsLibs.length, 3); assert.equal(auditResult.details.items[0][2].text, 'High'); assert.equal(auditResult.details.items[0][0].text, 'angular@1.1.4'); - assert.equal(auditResult.details.items[0][0].url, 'https://snyk.io/vuln/npm:angular#lh@1.1.4'); + assert.equal(auditResult.details.items[0][0].url, 'https://snyk.io/vuln/npm:angular?lh@1.1.4'); }); it('handles ill-specified versions', () => {