diff --git a/lighthouse-core/report/html/renderer/util.js b/lighthouse-core/report/html/renderer/util.js
index b059a2c75faf..8e41450fac2d 100644
--- a/lighthouse-core/report/html/renderer/util.js
+++ b/lighthouse-core/report/html/renderer/util.js
@@ -142,10 +142,7 @@ class Util {
case 'numeric':
case 'binary':
default:
- // Numeric audits that are within PASS_THRESHOLD will still show up with failing.
- // For opportunities, we want to have them show up with other failing for contrast.
- // For diagnostics, we sort by score so they'll be lowest priority.
- return Number(audit.score) === 1;
+ return Number(audit.score) >= RATINGS.PASS.minScore;
}
}
diff --git a/lighthouse-core/test/report/html/renderer/performance-category-renderer-test.js b/lighthouse-core/test/report/html/renderer/performance-category-renderer-test.js
index 8650cbf77d24..15781d576091 100644
--- a/lighthouse-core/test/report/html/renderer/performance-category-renderer-test.js
+++ b/lighthouse-core/test/report/html/renderer/performance-category-renderer-test.js
@@ -140,7 +140,7 @@ describe('PerfCategoryRenderer', () => {
const diagnosticSection = categoryDOM.querySelectorAll('.lh-category > .lh-audit-group')[2];
const diagnosticAudits = category.auditRefs.filter(audit => audit.group === 'diagnostics' &&
- audit.result.score !== 1 && audit.result.scoreDisplayMode !== 'not-applicable');
+ !Util.showAsPassed(audit.result));
const diagnosticElements = diagnosticSection.querySelectorAll('.lh-audit');
assert.equal(diagnosticElements.length, diagnosticAudits.length);
});
@@ -150,8 +150,7 @@ describe('PerfCategoryRenderer', () => {
const passedSection = categoryDOM.querySelector('.lh-category > .lh-passed-audits');
const passedAudits = category.auditRefs.filter(audit =>
- audit.group && audit.group !== 'metrics' &&
- (audit.result.score === 1 || audit.result.scoreDisplayMode === 'not-applicable'));
+ audit.group && audit.group !== 'metrics' && Util.showAsPassed(audit.result));
const passedElements = passedSection.querySelectorAll('.lh-audit');
assert.equal(passedElements.length, passedAudits.length);
});