From b435aedf64418cdf703d6db8ae7e9c343bfa8752 Mon Sep 17 00:00:00 2001 From: Paul Irish Date: Fri, 16 Nov 2018 00:03:04 -0800 Subject: [PATCH] core(driver): assert securityIssues before getPageLoadError --- lighthouse-core/gather/gather-runner.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lighthouse-core/gather/gather-runner.js b/lighthouse-core/gather/gather-runner.js index 6eaeb4b079c9..7c65e840b022 100644 --- a/lighthouse-core/gather/gather-runner.js +++ b/lighthouse-core/gather/gather-runner.js @@ -300,6 +300,8 @@ class GatherRunner { const networkRecords = NetworkRecorder.recordsFromLogs(devtoolsLog); log.timeEnd(status); + this.assertNoSecurityIssues(driver.getSecurityState()); + let pageLoadError = GatherRunner.getPageLoadError(passContext.url, networkRecords); // If the driver was offline, a page load error is expected, so do not save it. if (!driver.online) pageLoadError = undefined; @@ -309,8 +311,6 @@ class GatherRunner { passContext.LighthouseRunWarnings.push(pageLoadError.friendlyMessage); } - this.assertNoSecurityIssues(driver.getSecurityState()); - // Expose devtoolsLog, networkRecords, and trace (if present) to gatherers /** @type {LH.Gatherer.LoadData} */ const passData = {