From f6cb15bb8ea97d7fbd33ed00e925c963306203db Mon Sep 17 00:00:00 2001 From: Shane Exterkamp Date: Wed, 10 Apr 2019 10:57:31 -0700 Subject: [PATCH 1/8] added UIStrings and exported to en-US. --- lighthouse-core/lib/i18n/en-US.json | 56 +++++++++++++ .../scripts/i18n/collect-strings.js | 5 +- stack-packs/packs/wordpress.js | 78 ++++++++++++------- 3 files changed, 110 insertions(+), 29 deletions(-) diff --git a/lighthouse-core/lib/i18n/en-US.json b/lighthouse-core/lib/i18n/en-US.json index ff14f65606f6..73c7c38c03a3 100644 --- a/lighthouse-core/lib/i18n/en-US.json +++ b/lighthouse-core/lib/i18n/en-US.json @@ -1338,5 +1338,61 @@ "lighthouse-core/report/html/renderer/util.js | warningHeader": { "message": "Warnings: ", "description": "This label is shown above a bulleted list of warnings. It is shown directly below an audit that produced warnings. Warnings describe situations the user should be aware of, as Lighthouse was unable to complete all the work required on this audit. For example, The 'Unable to decode image (biglogo.jpg)' warning may show up below an image encoding audit." + }, + "stack-packs/packs/wordpress.js | efficient_animated_content": { + "message": "Consider uploading your GIF to a service which will make it available to embed as an HTML5 video.", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by encoding animationg in HTML5, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + }, + "stack-packs/packs/wordpress.js | offscreen_images": { + "message": "Install a [lazy-load WordPress plugin](https://wordpress.org/plugins/search/lazy+load/) that provides the ability to defer any offscreen images, or switch to a theme that provides that functionality. Also consider using [the AMP plugin](https://wordpress.org/plugins/amp/).", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by lazy loading images that are initially offscreen in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + }, + "stack-packs/packs/wordpress.js | render_blocking_resources": { + "message": "There are a number of WordPress plugins that can help you [inline critical assets](https://wordpress.org/plugins/search/critical+css/) or [defer less important resources](https://wordpress.org/plugins/search/defer+css+javascript/). Beware that optimizations provided by these plugins may break features of your theme or plugins, so you will likely need to make code changes.", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by reducing the amount of render blocking resources present on their page, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + }, + "stack-packs/packs/wordpress.js | time_to_first_byte": { + "message": "Themes, plugins, and server specifications all contribute to server response time. Consider finding a more optimized theme, carefully selecting an optimization plugin, and/or upgrading your server.", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve the time to first byte speed metric, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + }, + "stack-packs/packs/wordpress.js | total_byte_weight": { + "message": "Consider showing excerpts in your post lists (e.g. via the more tag), reducing the number of posts shown on a given page, breaking your long posts into multiple pages, or using a plugin to lazy-load comments.", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve site loading performance by reducing the total bytes delivered by their page in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + }, + "stack-packs/packs/wordpress.js | unminified_css": { + "message": "A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+css/) can speed up your site by concatenating, minifying, and compressing your styles. You may also want to use a build process to do this minification up-front if possible.", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by minifying their CSS files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + }, + "stack-packs/packs/wordpress.js | unminified_javascript": { + "message": "A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+javascript/) can speed up your site by concatenating, minifying, and compressing your scripts. You may also want to use a build process to do this minification up front if possible.", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by minifying their Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + }, + "stack-packs/packs/wordpress.js | unused_css_rules": { + "message": "Consider reducing, or switching, the number of [WordPress plugins](https://wordpress.org/plugins/) loading unused CSS in your page. To identify plugins that are adding extraneous CSS, try running [code coverage](https://developers.google.com/web/updates/2017/04/devtools-release-notes#coverage) in Chrome DevTools. You can identify the theme/plugin responsible from the URL of the stylesheet. Look out for plugins that have many stylesheets in the list which have a lot of red in code coverage. A plugin should only enqueue a stylesheet if it is actually used on the page.", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by removing unused CSS, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + }, + "stack-packs/packs/wordpress.js | unused_javascript": { + "message": "Consider reducing, or switching, the number of [WordPress plugins](https://wordpress.org/plugins/) loading unused JavaScript in your page. To identify plugins that are adding extraneous JS, try running [code coverage](https://developers.google.com/web/updates/2017/04/devtools-release-notes#coverage) in Chrome DevTools. You can identify the theme/plugin responsible from the URL of the script. Look out for plugins that have many scripts in the list which have a lot of red in code coverage. A plugin should only enqueue a script if it is actually used on the page.", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by removing unused Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + }, + "stack-packs/packs/wordpress.js | uses_long_cache_ttl": { + "message": "Read about [Browser Caching in WordPress](https://codex.wordpress.org/WordPress_Optimization#Browser_Caching).", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve their site by enabling long caching in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + }, + "stack-packs/packs/wordpress.js | uses_optimized_images": { + "message": "Consider using an [image optimization WordPress plugin](https://wordpress.org/plugins/search/optimize+images/) that compresses your images while retaining quality.", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve site performance by optimizing images, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + }, + "stack-packs/packs/wordpress.js | uses_responsive_images": { + "message": "Upload images directly through the [media library](https://codex.wordpress.org/Media_Library_Screen) to ensure that the required image sizes are available, and then insert them from the media library or use the image widget to ensure the optimal image sizes are used (including those for the responsive breakpoints). Avoid using `Full Size` images unless the dimensions are adequate for their usage. [Learn More](https://codex.wordpress.org/Inserting_Images_into_Posts_and_Pages#Image_Size).", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by using responsive images in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + }, + "stack-packs/packs/wordpress.js | uses_text_compression": { + "message": "You can enable text compression in your web server configuration.", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance via enabling text compression in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + }, + "stack-packs/packs/wordpress.js | uses_webp_images": { + "message": "Consider using a [plugin](https://wordpress.org/plugins/search/convert+webp/) or service that will automatically convert your uploaded images to the optimal formats.", + "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve image loading by using webp in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." } } diff --git a/lighthouse-core/scripts/i18n/collect-strings.js b/lighthouse-core/scripts/i18n/collect-strings.js index 469ad98fb72d..d266c8c72a21 100644 --- a/lighthouse-core/scripts/i18n/collect-strings.js +++ b/lighthouse-core/scripts/i18n/collect-strings.js @@ -113,7 +113,10 @@ function writeEnStringsToLocaleFormat(strings) { } const strings = collectAllStringsInDir(path.join(LH_ROOT, 'lighthouse-core')); -console.log('Collected!'); +console.log('Collected from LH core!'); + +collectAllStringsInDir(path.join(LH_ROOT, 'stack-packs/packs'), strings); +console.log('Collected from Stack Packs!'); writeEnStringsToLocaleFormat(strings); console.log('Written to disk!'); diff --git a/stack-packs/packs/wordpress.js b/stack-packs/packs/wordpress.js index d7463fd5db4b..07949af12c80 100644 --- a/stack-packs/packs/wordpress.js +++ b/stack-packs/packs/wordpress.js @@ -7,40 +7,62 @@ 'use strict'; +const i18n = require('../../lighthouse-core/lib/i18n/i18n.js'); + const wordpressIcon = `data:image/svg+xml,%3Csvg viewBox='0 0 122.5 122.5' xmlns='http://www.w3.org/2000/svg'%3E%3Cg fill='%2321759b'%3E%3Cpath d='M8.7 61.3c0 20.8 12.1 38.7 29.6 47.3l-25-68.7c-3 6.5-4.6 13.7-4.6 21.4zM96.7 58.6c0-6.5-2.3-11-4.3-14.5-2.7-4.3-5.2-8-5.2-12.3 0-4.8 3.7-9.3 8.9-9.3h.7a52.4 52.4 0 0 0-79.4 9.9h3.3c5.5 0 14-.6 14-.6 2.9-.2 3.2 4 .4 4.3 0 0-2.9.4-6 .5l19.1 57L59.7 59l-8.2-22.5c-2.8-.1-5.5-.5-5.5-.5-2.8-.1-2.5-4.5.3-4.3 0 0 8.7.7 13.9.7 5.5 0 14-.7 14-.7 2.8-.2 3.2 4 .3 4.3 0 0-2.8.4-6 .5l19 56.5 5.2-17.5c2.3-7.3 4-12.5 4-17z'/%3E%3Cpath d='M62.2 65.9l-15.8 45.8a52.6 52.6 0 0 0 32.3-.9l-.4-.7zM107.4 36a49.6 49.6 0 0 1-3.6 24.2l-16.1 46.5A52.5 52.5 0 0 0 107.4 36z'/%3E%3Cpath d='M61.3 0a61.3 61.3 0 1 0 .1 122.7A61.3 61.3 0 0 0 61.3 0zm0 119.7a58.5 58.5 0 1 1 .1-117 58.5 58.5 0 0 1-.1 117z'/%3E%3C/g%3E%3C/svg%3E`; +const UIStrings = { + /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by removing unused CSS, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + unused_css_rules: 'Consider reducing, or switching, the number of [WordPress plugins](https://wordpress.org/plugins/) loading unused CSS in your page. To identify plugins that are adding extraneous CSS, try running [code coverage](https://developers.google.com/web/updates/2017/04/devtools-release-notes#coverage) in Chrome DevTools. You can identify the theme/plugin responsible from the URL of the stylesheet. Look out for plugins that have many stylesheets in the list which have a lot of red in code coverage. A plugin should only enqueue a stylesheet if it is actually used on the page.', + /** Additional description of a Lighthouse audit that tells the user *how* they can improve image loading by using webp in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + uses_webp_images: 'Consider using a [plugin](https://wordpress.org/plugins/search/convert+webp/) or service that will automatically convert your uploaded images to the optimal formats.', + /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by lazy loading images that are initially offscreen in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + offscreen_images: 'Install a [lazy-load WordPress plugin](https://wordpress.org/plugins/search/lazy+load/) that provides the ability to defer any offscreen images, or switch to a theme that provides that functionality. Also consider using [the AMP plugin](https://wordpress.org/plugins/amp/).', + /** Additional description of a Lighthouse audit that tells the user *how* they can improve site loading performance by reducing the total bytes delivered by their page in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + total_byte_weight: 'Consider showing excerpts in your post lists (e.g. via the more tag), reducing the number of posts shown on a given page, breaking your long posts into multiple pages, or using a plugin to lazy-load comments.', + /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by reducing the amount of render blocking resources present on their page, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + render_blocking_resources: 'There are a number of WordPress plugins that can help you [inline critical assets](https://wordpress.org/plugins/search/critical+css/) or [defer less important resources](https://wordpress.org/plugins/search/defer+css+javascript/). Beware that optimizations provided by these plugins may break features of your theme or plugins, so you will likely need to make code changes.', + /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by minifying their CSS files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + unminified_css: 'A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+css/) can speed up your site by concatenating, minifying, and compressing your styles. You may also want to use a build process to do this minification up-front if possible.', + /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by minifying their Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + unminified_javascript: 'A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+javascript/) can speed up your site by concatenating, minifying, and compressing your scripts. You may also want to use a build process to do this minification up front if possible.', + /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by encoding animationg in HTML5, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + efficient_animated_content: 'Consider uploading your GIF to a service which will make it available to embed as an HTML5 video.', + /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by removing unused Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + unused_javascript: 'Consider reducing, or switching, the number of [WordPress plugins](https://wordpress.org/plugins/) loading unused JavaScript in your page. To identify plugins that are adding extraneous JS, try running [code coverage](https://developers.google.com/web/updates/2017/04/devtools-release-notes#coverage) in Chrome DevTools. You can identify the theme/plugin responsible from the URL of the script. Look out for plugins that have many scripts in the list which have a lot of red in code coverage. A plugin should only enqueue a script if it is actually used on the page.', + /** Additional description of a Lighthouse audit that tells the user *how* they can improve their site by enabling long caching in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + uses_long_cache_ttl: 'Read about [Browser Caching in WordPress](https://codex.wordpress.org/WordPress_Optimization#Browser_Caching).', + /** Additional description of a Lighthouse audit that tells the user *how* they can improve site performance by optimizing images, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + uses_optimized_images: 'Consider using an [image optimization WordPress plugin](https://wordpress.org/plugins/search/optimize+images/) that compresses your images while retaining quality.', + /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance via enabling text compression in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + uses_text_compression: 'You can enable text compression in your web server configuration.', + /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by using responsive images in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + uses_responsive_images: 'Upload images directly through the [media library](https://codex.wordpress.org/Media_Library_Screen) to ensure that the required image sizes are available, and then insert them from the media library or use the image widget to ensure the optimal image sizes are used (including those for the responsive breakpoints). Avoid using `Full Size` images unless the dimensions are adequate for their usage. [Learn More](https://codex.wordpress.org/Inserting_Images_into_Posts_and_Pages#Image_Size).', + /** Additional description of a Lighthouse audit that tells the user *how* they can improve the time to first byte speed metric, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + time_to_first_byte: 'Themes, plugins, and server specifications all contribute to server response time. Consider finding a more optimized theme, carefully selecting an optimization plugin, and/or upgrading your server.', +}; + +const str_ = i18n.createMessageInstanceIdFn(__filename, UIStrings); + module.exports = { id: 'wordpress', iconDataURL: wordpressIcon, title: 'WordPress', descriptions: { - 'unused-css-rules': - 'Consider reducing, or switching, the number of [WordPress plugins](https://wordpress.org/plugins/) loading unused CSS in your page. To identify plugins that are adding extraneous CSS, try running [code coverage](https://developers.google.com/web/updates/2017/04/devtools-release-notes#coverage) in Chrome DevTools. You can identify the theme/plugin responsible from the URL of the stylesheet. Look out for plugins that have many stylesheets in the list which have a lot of red in code coverage. A plugin should only enqueue a stylesheet if it is actually used on the page.', - 'uses-webp-images': - 'Consider using a [plugin](https://wordpress.org/plugins/search/convert+webp/) or service that will automatically convert your uploaded images to the optimal formats.', - 'offscreen-images': - 'Install a [lazy-load WordPress plugin](https://wordpress.org/plugins/search/lazy+load/) that provides the ability to defer any offscreen images, or switch to a theme that provides that functionality. Also consider using [the AMP plugin](https://wordpress.org/plugins/amp/).', - 'total-byte-weight': - 'Consider showing excerpts in your post lists (e.g. via the more tag), reducing the number of posts shown on a given page, breaking your long posts into multiple pages, or using a plugin to lazy-load comments.', - 'render-blocking-resources': - 'There are a number of WordPress plugins that can help you [inline critical assets](https://wordpress.org/plugins/search/critical+css/) or [defer less important resources](https://wordpress.org/plugins/search/defer+css+javascript/). Beware that optimizations provided by these plugins may break features of your theme or plugins, so you will likely need to make code changes.', - 'unminified-css': - 'A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+css/) can speed up your site by concatenating, minifying, and compressing your styles. You may also want to use a build process to do this minification up-front if possible.', - 'unminified-javascript': - 'A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+javascript/) can speed up your site by concatenating, minifying, and compressing your scripts. You may also want to use a build process to do this minification up front if possible.', - 'efficient-animated-content': - 'Consider uploading your GIF to a service which will make it available to embed as an HTML5 video.', - 'unused-javascript': - 'Consider reducing, or switching, the number of [WordPress plugins](https://wordpress.org/plugins/) loading unused JavaScript in your page. To identify plugins that are adding extraneous JS, try running [code coverage](https://developers.google.com/web/updates/2017/04/devtools-release-notes#coverage) in Chrome DevTools. You can identify the theme/plugin responsible from the URL of the script. Look out for plugins that have many scripts in the list which have a lot of red in code coverage. A plugin should only enqueue a script if it is actually used on the page.', - 'uses-long-cache-ttl': - 'Read about [Browser Caching in WordPress](https://codex.wordpress.org/WordPress_Optimization#Browser_Caching).', - 'uses-optimized-images': - 'Consider using an [image optimization WordPress plugin](https://wordpress.org/plugins/search/optimize+images/) that compresses your images while retaining quality.', - 'uses-text-compression': - 'You can enable this in your web server configuration.', - 'uses-responsive-images': - 'Upload images directly through the [media library](https://codex.wordpress.org/Media_Library_Screen) to ensure that the required image sizes are available, and then insert them from the media library or use the image widget to ensure the optimal image sizes are used (including those for the responsive breakpoints). Avoid using `Full Size` images unless the dimensions are adequate for their usage. [Learn More](https://codex.wordpress.org/Inserting_Images_into_Posts_and_Pages#Image_Size).', - 'time-to-first-byte': - 'Themes, plugins, and server specifications all contribute to server response time. Consider finding a more optimized theme, carefully selecting an optimization plugin, and/or upgrading your server.', + 'unused-css-rules': str_(UIStrings.unused_css_rules), + 'uses-webp-images': str_(UIStrings.uses_webp_images), + 'offscreen-images': str_(UIStrings.offscreen_images), + 'total-byte-weight': str_(UIStrings.total_byte_weight), + 'render-blocking-resources': str_(UIStrings.render_blocking_resources), + 'unminified-css': str_(UIStrings.unminified_css), + 'unminified-javascript': str_(UIStrings.unminified_javascript), + 'efficient-animated-content': str_(UIStrings.efficient_animated_content), + 'unused-javascript': str_(UIStrings.unused_javascript), + 'uses-long-cache-ttl': str_(UIStrings.uses_long_cache_ttl), + 'uses-optimized-images': str_(UIStrings.uses_optimized_images), + 'uses-text-compression': str_(UIStrings.uses_text_compression), + 'uses-responsive-images': str_(UIStrings.uses_responsive_images), + 'time-to-first-byte': str_(UIStrings.time_to_first_byte), }, }; +module.exports.UIStrings = UIStrings; From 77d0c326eb0b2de93cdaa8ddc5b827bb6d88fe27 Mon Sep 17 00:00:00 2001 From: Shane Exterkamp Date: Wed, 10 Apr 2019 22:55:00 -0700 Subject: [PATCH 2/8] Spell check and remove emphasis. --- stack-packs/packs/wordpress.js | 28 ++++++++++++++-------------- 1 file changed, 14 insertions(+), 14 deletions(-) diff --git a/stack-packs/packs/wordpress.js b/stack-packs/packs/wordpress.js index 07949af12c80..bf21c67f87cb 100644 --- a/stack-packs/packs/wordpress.js +++ b/stack-packs/packs/wordpress.js @@ -12,33 +12,33 @@ const i18n = require('../../lighthouse-core/lib/i18n/i18n.js'); const wordpressIcon = `data:image/svg+xml,%3Csvg viewBox='0 0 122.5 122.5' xmlns='http://www.w3.org/2000/svg'%3E%3Cg fill='%2321759b'%3E%3Cpath d='M8.7 61.3c0 20.8 12.1 38.7 29.6 47.3l-25-68.7c-3 6.5-4.6 13.7-4.6 21.4zM96.7 58.6c0-6.5-2.3-11-4.3-14.5-2.7-4.3-5.2-8-5.2-12.3 0-4.8 3.7-9.3 8.9-9.3h.7a52.4 52.4 0 0 0-79.4 9.9h3.3c5.5 0 14-.6 14-.6 2.9-.2 3.2 4 .4 4.3 0 0-2.9.4-6 .5l19.1 57L59.7 59l-8.2-22.5c-2.8-.1-5.5-.5-5.5-.5-2.8-.1-2.5-4.5.3-4.3 0 0 8.7.7 13.9.7 5.5 0 14-.7 14-.7 2.8-.2 3.2 4 .3 4.3 0 0-2.8.4-6 .5l19 56.5 5.2-17.5c2.3-7.3 4-12.5 4-17z'/%3E%3Cpath d='M62.2 65.9l-15.8 45.8a52.6 52.6 0 0 0 32.3-.9l-.4-.7zM107.4 36a49.6 49.6 0 0 1-3.6 24.2l-16.1 46.5A52.5 52.5 0 0 0 107.4 36z'/%3E%3Cpath d='M61.3 0a61.3 61.3 0 1 0 .1 122.7A61.3 61.3 0 0 0 61.3 0zm0 119.7a58.5 58.5 0 1 1 .1-117 58.5 58.5 0 0 1-.1 117z'/%3E%3C/g%3E%3C/svg%3E`; const UIStrings = { - /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by removing unused CSS, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve performance by removing unused CSS, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ unused_css_rules: 'Consider reducing, or switching, the number of [WordPress plugins](https://wordpress.org/plugins/) loading unused CSS in your page. To identify plugins that are adding extraneous CSS, try running [code coverage](https://developers.google.com/web/updates/2017/04/devtools-release-notes#coverage) in Chrome DevTools. You can identify the theme/plugin responsible from the URL of the stylesheet. Look out for plugins that have many stylesheets in the list which have a lot of red in code coverage. A plugin should only enqueue a stylesheet if it is actually used on the page.', - /** Additional description of a Lighthouse audit that tells the user *how* they can improve image loading by using webp in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve image loading by using webp in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ uses_webp_images: 'Consider using a [plugin](https://wordpress.org/plugins/search/convert+webp/) or service that will automatically convert your uploaded images to the optimal formats.', - /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by lazy loading images that are initially offscreen in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve performance by lazy loading images that are initially offscreen in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ offscreen_images: 'Install a [lazy-load WordPress plugin](https://wordpress.org/plugins/search/lazy+load/) that provides the ability to defer any offscreen images, or switch to a theme that provides that functionality. Also consider using [the AMP plugin](https://wordpress.org/plugins/amp/).', - /** Additional description of a Lighthouse audit that tells the user *how* they can improve site loading performance by reducing the total bytes delivered by their page in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve site loading performance by reducing the total bytes delivered by their page in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ total_byte_weight: 'Consider showing excerpts in your post lists (e.g. via the more tag), reducing the number of posts shown on a given page, breaking your long posts into multiple pages, or using a plugin to lazy-load comments.', - /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by reducing the amount of render blocking resources present on their page, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve performance by reducing the amount of render blocking resources present on their page, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ render_blocking_resources: 'There are a number of WordPress plugins that can help you [inline critical assets](https://wordpress.org/plugins/search/critical+css/) or [defer less important resources](https://wordpress.org/plugins/search/defer+css+javascript/). Beware that optimizations provided by these plugins may break features of your theme or plugins, so you will likely need to make code changes.', - /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by minifying their CSS files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve performance by minifying their CSS files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ unminified_css: 'A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+css/) can speed up your site by concatenating, minifying, and compressing your styles. You may also want to use a build process to do this minification up-front if possible.', - /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by minifying their Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve performance by minifying their Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ unminified_javascript: 'A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+javascript/) can speed up your site by concatenating, minifying, and compressing your scripts. You may also want to use a build process to do this minification up front if possible.', - /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by encoding animationg in HTML5, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve performance by encoding animations in HTML5, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ efficient_animated_content: 'Consider uploading your GIF to a service which will make it available to embed as an HTML5 video.', - /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by removing unused Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve performance by removing unused Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ unused_javascript: 'Consider reducing, or switching, the number of [WordPress plugins](https://wordpress.org/plugins/) loading unused JavaScript in your page. To identify plugins that are adding extraneous JS, try running [code coverage](https://developers.google.com/web/updates/2017/04/devtools-release-notes#coverage) in Chrome DevTools. You can identify the theme/plugin responsible from the URL of the script. Look out for plugins that have many scripts in the list which have a lot of red in code coverage. A plugin should only enqueue a script if it is actually used on the page.', - /** Additional description of a Lighthouse audit that tells the user *how* they can improve their site by enabling long caching in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve their site by enabling long caching in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ uses_long_cache_ttl: 'Read about [Browser Caching in WordPress](https://codex.wordpress.org/WordPress_Optimization#Browser_Caching).', - /** Additional description of a Lighthouse audit that tells the user *how* they can improve site performance by optimizing images, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve site performance by optimizing images, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ uses_optimized_images: 'Consider using an [image optimization WordPress plugin](https://wordpress.org/plugins/search/optimize+images/) that compresses your images while retaining quality.', - /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance via enabling text compression in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve performance via enabling text compression in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ uses_text_compression: 'You can enable text compression in your web server configuration.', - /** Additional description of a Lighthouse audit that tells the user *how* they can improve performance by using responsive images in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve performance by using responsive images in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ uses_responsive_images: 'Upload images directly through the [media library](https://codex.wordpress.org/Media_Library_Screen) to ensure that the required image sizes are available, and then insert them from the media library or use the image widget to ensure the optimal image sizes are used (including those for the responsive breakpoints). Avoid using `Full Size` images unless the dimensions are adequate for their usage. [Learn More](https://codex.wordpress.org/Inserting_Images_into_Posts_and_Pages#Image_Size).', - /** Additional description of a Lighthouse audit that tells the user *how* they can improve the time to first byte speed metric, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve the time to first byte speed metric, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ time_to_first_byte: 'Themes, plugins, and server specifications all contribute to server response time. Consider finding a more optimized theme, carefully selecting an optimization plugin, and/or upgrading your server.', }; From 84ff79e784833d1e9f5dc9e2eba50cf3731ee7f5 Mon Sep 17 00:00:00 2001 From: Shane Exterkamp Date: Wed, 10 Apr 2019 22:55:57 -0700 Subject: [PATCH 3/8] Use brendans wording. --- stack-packs/packs/wordpress.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stack-packs/packs/wordpress.js b/stack-packs/packs/wordpress.js index bf21c67f87cb..a15194acae4d 100644 --- a/stack-packs/packs/wordpress.js +++ b/stack-packs/packs/wordpress.js @@ -26,7 +26,7 @@ const UIStrings = { unminified_css: 'A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+css/) can speed up your site by concatenating, minifying, and compressing your styles. You may also want to use a build process to do this minification up-front if possible.', /** Additional description of a Lighthouse audit that tells the user how they can improve performance by minifying their Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ unminified_javascript: 'A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+javascript/) can speed up your site by concatenating, minifying, and compressing your scripts. You may also want to use a build process to do this minification up front if possible.', - /** Additional description of a Lighthouse audit that tells the user how they can improve performance by encoding animations in HTML5, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ + /** Additional description of a Lighthouse audit that tells the user how they can improve performance by encoding animated images as video, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ efficient_animated_content: 'Consider uploading your GIF to a service which will make it available to embed as an HTML5 video.', /** Additional description of a Lighthouse audit that tells the user how they can improve performance by removing unused Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation. */ unused_javascript: 'Consider reducing, or switching, the number of [WordPress plugins](https://wordpress.org/plugins/) loading unused JavaScript in your page. To identify plugins that are adding extraneous JS, try running [code coverage](https://developers.google.com/web/updates/2017/04/devtools-release-notes#coverage) in Chrome DevTools. You can identify the theme/plugin responsible from the URL of the script. Look out for plugins that have many scripts in the list which have a lot of red in code coverage. A plugin should only enqueue a script if it is actually used on the page.', From d1d3f2eb6656594a0f18c814ebc6c891e132e746 Mon Sep 17 00:00:00 2001 From: Shane Exterkamp Date: Thu, 11 Apr 2019 12:08:24 -0700 Subject: [PATCH 4/8] Collect new strings for extraction and update round trip. --- lighthouse-core/lib/i18n/en-US.json | 28 ++++++++++++++-------------- proto/sample_v2_round_trip.json | 3 +-- 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/lighthouse-core/lib/i18n/en-US.json b/lighthouse-core/lib/i18n/en-US.json index 73c7c38c03a3..3de20188d77a 100644 --- a/lighthouse-core/lib/i18n/en-US.json +++ b/lighthouse-core/lib/i18n/en-US.json @@ -1341,58 +1341,58 @@ }, "stack-packs/packs/wordpress.js | efficient_animated_content": { "message": "Consider uploading your GIF to a service which will make it available to embed as an HTML5 video.", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by encoding animationg in HTML5, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve performance by encoding animated images as video, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." }, "stack-packs/packs/wordpress.js | offscreen_images": { "message": "Install a [lazy-load WordPress plugin](https://wordpress.org/plugins/search/lazy+load/) that provides the ability to defer any offscreen images, or switch to a theme that provides that functionality. Also consider using [the AMP plugin](https://wordpress.org/plugins/amp/).", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by lazy loading images that are initially offscreen in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve performance by lazy loading images that are initially offscreen in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." }, "stack-packs/packs/wordpress.js | render_blocking_resources": { "message": "There are a number of WordPress plugins that can help you [inline critical assets](https://wordpress.org/plugins/search/critical+css/) or [defer less important resources](https://wordpress.org/plugins/search/defer+css+javascript/). Beware that optimizations provided by these plugins may break features of your theme or plugins, so you will likely need to make code changes.", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by reducing the amount of render blocking resources present on their page, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve performance by reducing the amount of render blocking resources present on their page, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." }, "stack-packs/packs/wordpress.js | time_to_first_byte": { "message": "Themes, plugins, and server specifications all contribute to server response time. Consider finding a more optimized theme, carefully selecting an optimization plugin, and/or upgrading your server.", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve the time to first byte speed metric, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve the time to first byte speed metric, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." }, "stack-packs/packs/wordpress.js | total_byte_weight": { "message": "Consider showing excerpts in your post lists (e.g. via the more tag), reducing the number of posts shown on a given page, breaking your long posts into multiple pages, or using a plugin to lazy-load comments.", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve site loading performance by reducing the total bytes delivered by their page in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve site loading performance by reducing the total bytes delivered by their page in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." }, "stack-packs/packs/wordpress.js | unminified_css": { "message": "A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+css/) can speed up your site by concatenating, minifying, and compressing your styles. You may also want to use a build process to do this minification up-front if possible.", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by minifying their CSS files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve performance by minifying their CSS files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." }, "stack-packs/packs/wordpress.js | unminified_javascript": { "message": "A number of [WordPress plugins](https://wordpress.org/plugins/search/minify+javascript/) can speed up your site by concatenating, minifying, and compressing your scripts. You may also want to use a build process to do this minification up front if possible.", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by minifying their Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve performance by minifying their Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." }, "stack-packs/packs/wordpress.js | unused_css_rules": { "message": "Consider reducing, or switching, the number of [WordPress plugins](https://wordpress.org/plugins/) loading unused CSS in your page. To identify plugins that are adding extraneous CSS, try running [code coverage](https://developers.google.com/web/updates/2017/04/devtools-release-notes#coverage) in Chrome DevTools. You can identify the theme/plugin responsible from the URL of the stylesheet. Look out for plugins that have many stylesheets in the list which have a lot of red in code coverage. A plugin should only enqueue a stylesheet if it is actually used on the page.", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by removing unused CSS, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve performance by removing unused CSS, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." }, "stack-packs/packs/wordpress.js | unused_javascript": { "message": "Consider reducing, or switching, the number of [WordPress plugins](https://wordpress.org/plugins/) loading unused JavaScript in your page. To identify plugins that are adding extraneous JS, try running [code coverage](https://developers.google.com/web/updates/2017/04/devtools-release-notes#coverage) in Chrome DevTools. You can identify the theme/plugin responsible from the URL of the script. Look out for plugins that have many scripts in the list which have a lot of red in code coverage. A plugin should only enqueue a script if it is actually used on the page.", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by removing unused Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve performance by removing unused Javascript files in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." }, "stack-packs/packs/wordpress.js | uses_long_cache_ttl": { "message": "Read about [Browser Caching in WordPress](https://codex.wordpress.org/WordPress_Optimization#Browser_Caching).", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve their site by enabling long caching in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve their site by enabling long caching in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." }, "stack-packs/packs/wordpress.js | uses_optimized_images": { "message": "Consider using an [image optimization WordPress plugin](https://wordpress.org/plugins/search/optimize+images/) that compresses your images while retaining quality.", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve site performance by optimizing images, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve site performance by optimizing images, in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." }, "stack-packs/packs/wordpress.js | uses_responsive_images": { "message": "Upload images directly through the [media library](https://codex.wordpress.org/Media_Library_Screen) to ensure that the required image sizes are available, and then insert them from the media library or use the image widget to ensure the optimal image sizes are used (including those for the responsive breakpoints). Avoid using `Full Size` images unless the dimensions are adequate for their usage. [Learn More](https://codex.wordpress.org/Inserting_Images_into_Posts_and_Pages#Image_Size).", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance by using responsive images in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve performance by using responsive images in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." }, "stack-packs/packs/wordpress.js | uses_text_compression": { "message": "You can enable text compression in your web server configuration.", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve performance via enabling text compression in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve performance via enabling text compression in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." }, "stack-packs/packs/wordpress.js | uses_webp_images": { "message": "Consider using a [plugin](https://wordpress.org/plugins/search/convert+webp/) or service that will automatically convert your uploaded images to the optimal formats.", - "description": "Additional description of a Lighthouse audit that tells the user *how* they can improve image loading by using webp in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." + "description": "Additional description of a Lighthouse audit that tells the user how they can improve image loading by using webp in the context of the Wordpress CMS platform. This is displayed after a user expands the section to see more. No character length limits. Links in (parenthesis) become link texts to additional documentation." } } diff --git a/proto/sample_v2_round_trip.json b/proto/sample_v2_round_trip.json index c1359189dc86..df65231d8cfc 100644 --- a/proto/sample_v2_round_trip.json +++ b/proto/sample_v2_round_trip.json @@ -3603,8 +3603,7 @@ "warningAuditsGroupTitle": "Passed audits but with warnings", "warningHeader": "Warnings: " } - }, - "stackPacks": [], + }, "lighthouseVersion": "4.3.0", "requestedUrl": "http://localhost:10200/dobetterweb/dbw_tester.html", "runWarnings": [], From 4713efee4883001d63b21e67c9effad58ad8ed2c Mon Sep 17 00:00:00 2001 From: Shane Exterkamp Date: Mon, 15 Apr 2019 11:19:44 -0700 Subject: [PATCH 5/8] Removed @lighthouse/stack-pack local package. --- lighthouse-core/lib/stack-packs.js | 2 +- package.json | 3 +-- stack-packs/package.json | 18 ------------------ 3 files changed, 2 insertions(+), 21 deletions(-) delete mode 100644 stack-packs/package.json diff --git a/lighthouse-core/lib/stack-packs.js b/lighthouse-core/lib/stack-packs.js index ae9d8ea9c786..76cdb9542e2f 100644 --- a/lighthouse-core/lib/stack-packs.js +++ b/lighthouse-core/lib/stack-packs.js @@ -5,7 +5,7 @@ */ 'use strict'; -const stackPacks = require('@lighthouse/stack-packs'); +const stackPacks = require('../../stack-packs/index.js'); const stackPacksToInclude = [{ packId: 'wordpress', diff --git a/package.json b/package.json index 0a8f1fc8fa3a..316d55b8315e 100644 --- a/package.json +++ b/package.json @@ -158,8 +158,7 @@ "update-notifier": "^2.5.0", "ws": "3.3.2", "yargs": "3.32.0", - "yargs-parser": "7.0.0", - "@lighthouse/stack-packs": "file:./stack-packs" + "yargs-parser": "7.0.0" }, "resolutions": { "chrome-launcher/@types/node": "*" diff --git a/stack-packs/package.json b/stack-packs/package.json deleted file mode 100644 index e60682c216c6..000000000000 --- a/stack-packs/package.json +++ /dev/null @@ -1,18 +0,0 @@ -{ - "name": "@lighthouse/stack-packs", - "version": "1.0.0", - "description": "List of stackpacks used in Lighthouse", - "main": "./index.js", - "repository": "GoogleChrome/lighthouse-stack-packs", - "keywords": [ - "google", - "chrome", - "devtools" - ], - "author": "The Chromium Authors", - "license": "Apache-2.0", - "bugs": { - "url": "https://github.com/GoogleChrome/lighthouse-stack-packs/issues" - }, - "types": "./stack-packs.d.ts" -} From eca21c7e3d1eca5519b59e40778583068d5f15b2 Mon Sep 17 00:00:00 2001 From: Shane Exterkamp Date: Mon, 15 Apr 2019 11:23:06 -0700 Subject: [PATCH 6/8] readd stack-packs: [] to sample round trip. --- proto/sample_v2_round_trip.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/proto/sample_v2_round_trip.json b/proto/sample_v2_round_trip.json index df65231d8cfc..99171d938f2f 100644 --- a/proto/sample_v2_round_trip.json +++ b/proto/sample_v2_round_trip.json @@ -3606,7 +3606,8 @@ }, "lighthouseVersion": "4.3.0", "requestedUrl": "http://localhost:10200/dobetterweb/dbw_tester.html", - "runWarnings": [], + "runWarnings": [], + "stackPacks": [], "timing": { "entries": [ { From 369330629b041c41131a40396347234a81267a2b Mon Sep 17 00:00:00 2001 From: Shane Exterkamp Date: Mon, 15 Apr 2019 12:27:39 -0700 Subject: [PATCH 7/8] merge conflict got messed up --- proto/sample_v2_round_trip.json | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/proto/sample_v2_round_trip.json b/proto/sample_v2_round_trip.json index 37ec916819ba..0732720e2007 100644 --- a/proto/sample_v2_round_trip.json +++ b/proto/sample_v2_round_trip.json @@ -3613,11 +3613,7 @@ "warningAuditsGroupTitle": "Passed audits but with warnings", "warningHeader": "Warnings: " } - }, -<<<<<<< HEAD -======= - "stackPacks": [], ->>>>>>> master + }, "lighthouseVersion": "4.3.0", "requestedUrl": "http://localhost:10200/dobetterweb/dbw_tester.html", "runWarnings": [], From 1d0b40bdfd758ce3f6417f8e818d92623257c073 Mon Sep 17 00:00:00 2001 From: Shane Exterkamp Date: Tue, 16 Apr 2019 13:29:22 -0700 Subject: [PATCH 8/8] Add package.json for stack-packs, remove from yarn. --- package.json | 1 - stack-packs/package.json | 19 +++++++++++++++++++ yarn.lock | 3 --- 3 files changed, 19 insertions(+), 4 deletions(-) create mode 100644 stack-packs/package.json diff --git a/package.json b/package.json index fc8485f48038..ed25bc7fbe2d 100644 --- a/package.json +++ b/package.json @@ -131,7 +131,6 @@ "zone.js": "^0.7.3" }, "dependencies": { - "@lighthouse/stack-packs": "file:./stack-packs", "axe-core": "3.1.2", "chrome-launcher": "^0.10.5", "configstore": "^3.1.1", diff --git a/stack-packs/package.json b/stack-packs/package.json new file mode 100644 index 000000000000..a397db221d47 --- /dev/null +++ b/stack-packs/package.json @@ -0,0 +1,19 @@ +{ + "name": "@lighthouse/stack-packs", + "version": "1.0.0", + "description": "List of stackpacks used in Lighthouse", + "main": "./index.js", + "repository": "GoogleChrome/lighthouse-stack-packs", + "keywords": [ + "google", + "chrome", + "devtools", + "lighthouse" + ], + "author": "The Chromium Authors", + "license": "Apache-2.0", + "bugs": { + "url": "https://github.com/GoogleChrome/lighthouse-stack-packs/issues" + }, + "types": "./stack-packs.d.ts" +} diff --git a/yarn.lock b/yarn.lock index 363e9e303e9c..73776e799263 100644 --- a/yarn.lock +++ b/yarn.lock @@ -293,9 +293,6 @@ "@types/istanbul-lib-coverage" "^1.1.0" "@types/yargs" "^12.0.9" -"@lighthouse/stack-packs@file:./stack-packs": - version "1.0.0" - "@mrmlnc/readdir-enhanced@^2.2.1": version "2.2.1" resolved "https://registry.yarnpkg.com/@mrmlnc/readdir-enhanced/-/readdir-enhanced-2.2.1.tgz#524af240d1a360527b730475ecfa1344aa540dde"