From aa35ae9938f2b96b0dbcef1decd78d9e3817bdde Mon Sep 17 00:00:00 2001 From: Rob Dodson Date: Thu, 2 May 2019 17:18:36 -0700 Subject: [PATCH 1/8] Add new a11y weights. --- lighthouse-core/config/default-config.js | 60 ++++++++++++------------ 1 file changed, 30 insertions(+), 30 deletions(-) diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js index 5f5beb393de9..a188d8d79686 100644 --- a/lighthouse-core/config/default-config.js +++ b/lighthouse-core/config/default-config.js @@ -396,40 +396,40 @@ const defaultConfig = { description: str_(UIStrings.a11yCategoryDescription), manualDescription: str_(UIStrings.a11yCategoryManualDescription), auditRefs: [ - {id: 'accesskeys', weight: 3, group: 'a11y-navigation'}, + {id: 'accesskeys', weight: 2, group: 'a11y-navigation'}, {id: 'aria-allowed-attr', weight: 3, group: 'a11y-aria'}, - {id: 'aria-required-attr', weight: 2, group: 'a11y-aria'}, - {id: 'aria-required-children', weight: 5, group: 'a11y-aria'}, - {id: 'aria-required-parent', weight: 2, group: 'a11y-aria'}, + {id: 'aria-required-attr', weight: 3, group: 'a11y-aria'}, + {id: 'aria-required-children', weight: 3, group: 'a11y-aria'}, + {id: 'aria-required-parent', weight: 3, group: 'a11y-aria'}, {id: 'aria-roles', weight: 3, group: 'a11y-aria'}, - {id: 'aria-valid-attr-value', weight: 2, group: 'a11y-aria'}, - {id: 'aria-valid-attr', weight: 5, group: 'a11y-aria'}, - {id: 'audio-caption', weight: 4, group: 'a11y-audio-video'}, - {id: 'button-name', weight: 10, group: 'a11y-names-labels'}, - {id: 'bypass', weight: 10, group: 'a11y-navigation'}, - {id: 'color-contrast', weight: 6, group: 'a11y-color-contrast'}, - {id: 'definition-list', weight: 1, group: 'a11y-tables-lists'}, - {id: 'dlitem', weight: 1, group: 'a11y-tables-lists'}, + {id: 'aria-valid-attr-value', weight: 3, group: 'a11y-aria'}, + {id: 'aria-valid-attr', weight: 3, group: 'a11y-aria'}, + {id: 'audio-caption', weight: 3, group: 'a11y-audio-video'}, + {id: 'button-name', weight: 3, group: 'a11y-names-labels'}, + {id: 'bypass', weight: 2, group: 'a11y-navigation'}, + {id: 'color-contrast', weight: 2, group: 'a11y-color-contrast'}, + {id: 'definition-list', weight: 2, group: 'a11y-tables-lists'}, + {id: 'dlitem', weight: 2, group: 'a11y-tables-lists'}, {id: 'document-title', weight: 2, group: 'a11y-names-labels'}, - {id: 'duplicate-id', weight: 5, group: 'a11y-best-practices'}, - {id: 'frame-title', weight: 5, group: 'a11y-names-labels'}, - {id: 'html-has-lang', weight: 4, group: 'a11y-language'}, - {id: 'html-lang-valid', weight: 1, group: 'a11y-language'}, - {id: 'image-alt', weight: 8, group: 'a11y-names-labels'}, - {id: 'input-image-alt', weight: 1, group: 'a11y-names-labels'}, - {id: 'label', weight: 10, group: 'a11y-names-labels'}, - {id: 'layout-table', weight: 1, group: 'a11y-tables-lists'}, - {id: 'link-name', weight: 9, group: 'a11y-names-labels'}, - {id: 'list', weight: 5, group: 'a11y-tables-lists'}, - {id: 'listitem', weight: 4, group: 'a11y-tables-lists'}, - {id: 'meta-refresh', weight: 1, group: 'a11y-best-practices'}, + {id: 'duplicate-id', weight: 1, group: 'a11y-best-practices'}, + {id: 'frame-title', weight: 2, group: 'a11y-names-labels'}, + {id: 'html-has-lang', weight: 2, group: 'a11y-language'}, + {id: 'html-lang-valid', weight: 2, group: 'a11y-language'}, + {id: 'image-alt', weight: 3, group: 'a11y-names-labels'}, + {id: 'input-image-alt', weight: 3, group: 'a11y-names-labels'}, + {id: 'label', weight: 3, group: 'a11y-names-labels'}, + {id: 'layout-table', weight: 2, group: 'a11y-tables-lists'}, + {id: 'link-name', weight: 2, group: 'a11y-names-labels'}, + {id: 'list', weight: 2, group: 'a11y-tables-lists'}, + {id: 'listitem', weight: 2, group: 'a11y-tables-lists'}, + {id: 'meta-refresh', weight: 3, group: 'a11y-best-practices'}, {id: 'meta-viewport', weight: 3, group: 'a11y-best-practices'}, - {id: 'object-alt', weight: 4, group: 'a11y-names-labels'}, - {id: 'tabindex', weight: 4, group: 'a11y-navigation'}, - {id: 'td-headers-attr', weight: 1, group: 'a11y-tables-lists'}, - {id: 'th-has-data-cells', weight: 1, group: 'a11y-tables-lists'}, - {id: 'valid-lang', weight: 1, group: 'a11y-language'}, - {id: 'video-caption', weight: 4, group: 'a11y-audio-video'}, + {id: 'object-alt', weight: 2, group: 'a11y-names-labels'}, + {id: 'tabindex', weight: 2, group: 'a11y-navigation'}, + {id: 'td-headers-attr', weight: 2, group: 'a11y-tables-lists'}, + {id: 'th-has-data-cells', weight: 2, group: 'a11y-tables-lists'}, + {id: 'valid-lang', weight: 2, group: 'a11y-language'}, + {id: 'video-caption', weight: 3, group: 'a11y-audio-video'}, {id: 'video-description', weight: 3, group: 'a11y-audio-video'}, // Manual audits {id: 'logical-tab-order', weight: 0}, From d66841d3f6127d48f605f25b5b96ee6c952610b0 Mon Sep 17 00:00:00 2001 From: Rob Dodson Date: Thu, 2 May 2019 22:20:42 -0700 Subject: [PATCH 2/8] Stagger scores more. --- lighthouse-core/config/default-config.js | 68 ++++++++++++------------ 1 file changed, 34 insertions(+), 34 deletions(-) diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js index a188d8d79686..b59f942e2f3c 100644 --- a/lighthouse-core/config/default-config.js +++ b/lighthouse-core/config/default-config.js @@ -396,41 +396,41 @@ const defaultConfig = { description: str_(UIStrings.a11yCategoryDescription), manualDescription: str_(UIStrings.a11yCategoryManualDescription), auditRefs: [ - {id: 'accesskeys', weight: 2, group: 'a11y-navigation'}, - {id: 'aria-allowed-attr', weight: 3, group: 'a11y-aria'}, - {id: 'aria-required-attr', weight: 3, group: 'a11y-aria'}, - {id: 'aria-required-children', weight: 3, group: 'a11y-aria'}, - {id: 'aria-required-parent', weight: 3, group: 'a11y-aria'}, - {id: 'aria-roles', weight: 3, group: 'a11y-aria'}, - {id: 'aria-valid-attr-value', weight: 3, group: 'a11y-aria'}, - {id: 'aria-valid-attr', weight: 3, group: 'a11y-aria'}, - {id: 'audio-caption', weight: 3, group: 'a11y-audio-video'}, - {id: 'button-name', weight: 3, group: 'a11y-names-labels'}, - {id: 'bypass', weight: 2, group: 'a11y-navigation'}, - {id: 'color-contrast', weight: 2, group: 'a11y-color-contrast'}, - {id: 'definition-list', weight: 2, group: 'a11y-tables-lists'}, - {id: 'dlitem', weight: 2, group: 'a11y-tables-lists'}, - {id: 'document-title', weight: 2, group: 'a11y-names-labels'}, + {id: 'accesskeys', weight: 3, group: 'a11y-navigation'}, + {id: 'aria-allowed-attr', weight: 10, group: 'a11y-aria'}, + {id: 'aria-required-attr', weight: 10, group: 'a11y-aria'}, + {id: 'aria-required-children', weight: 10, group: 'a11y-aria'}, + {id: 'aria-required-parent', weight: 10, group: 'a11y-aria'}, + {id: 'aria-roles', weight: 10, group: 'a11y-aria'}, + {id: 'aria-valid-attr-value', weight: 10, group: 'a11y-aria'}, + {id: 'aria-valid-attr', weight: 10, group: 'a11y-aria'}, + {id: 'audio-caption', weight: 10, group: 'a11y-audio-video'}, + {id: 'button-name', weight: 10, group: 'a11y-names-labels'}, + {id: 'bypass', weight: 3, group: 'a11y-navigation'}, + {id: 'color-contrast', weight: 3, group: 'a11y-color-contrast'}, + {id: 'definition-list', weight: 3, group: 'a11y-tables-lists'}, + {id: 'dlitem', weight: 3, group: 'a11y-tables-lists'}, + {id: 'document-title', weight: 3, group: 'a11y-names-labels'}, {id: 'duplicate-id', weight: 1, group: 'a11y-best-practices'}, - {id: 'frame-title', weight: 2, group: 'a11y-names-labels'}, - {id: 'html-has-lang', weight: 2, group: 'a11y-language'}, - {id: 'html-lang-valid', weight: 2, group: 'a11y-language'}, - {id: 'image-alt', weight: 3, group: 'a11y-names-labels'}, - {id: 'input-image-alt', weight: 3, group: 'a11y-names-labels'}, - {id: 'label', weight: 3, group: 'a11y-names-labels'}, - {id: 'layout-table', weight: 2, group: 'a11y-tables-lists'}, - {id: 'link-name', weight: 2, group: 'a11y-names-labels'}, - {id: 'list', weight: 2, group: 'a11y-tables-lists'}, - {id: 'listitem', weight: 2, group: 'a11y-tables-lists'}, - {id: 'meta-refresh', weight: 3, group: 'a11y-best-practices'}, - {id: 'meta-viewport', weight: 3, group: 'a11y-best-practices'}, - {id: 'object-alt', weight: 2, group: 'a11y-names-labels'}, - {id: 'tabindex', weight: 2, group: 'a11y-navigation'}, - {id: 'td-headers-attr', weight: 2, group: 'a11y-tables-lists'}, - {id: 'th-has-data-cells', weight: 2, group: 'a11y-tables-lists'}, - {id: 'valid-lang', weight: 2, group: 'a11y-language'}, - {id: 'video-caption', weight: 3, group: 'a11y-audio-video'}, - {id: 'video-description', weight: 3, group: 'a11y-audio-video'}, + {id: 'frame-title', weight: 3, group: 'a11y-names-labels'}, + {id: 'html-has-lang', weight: 3, group: 'a11y-language'}, + {id: 'html-lang-valid', weight: 3, group: 'a11y-language'}, + {id: 'image-alt', weight: 10, group: 'a11y-names-labels'}, + {id: 'input-image-alt', weight: 10, group: 'a11y-names-labels'}, + {id: 'label', weight: 10, group: 'a11y-names-labels'}, + {id: 'layout-table', weight: 3, group: 'a11y-tables-lists'}, + {id: 'link-name', weight: 3, group: 'a11y-names-labels'}, + {id: 'list', weight: 3, group: 'a11y-tables-lists'}, + {id: 'listitem', weight: 3, group: 'a11y-tables-lists'}, + {id: 'meta-refresh', weight: 10, group: 'a11y-best-practices'}, + {id: 'meta-viewport', weight: 10, group: 'a11y-best-practices'}, + {id: 'object-alt', weight: 3, group: 'a11y-names-labels'}, + {id: 'tabindex', weight: 3, group: 'a11y-navigation'}, + {id: 'td-headers-attr', weight: 3, group: 'a11y-tables-lists'}, + {id: 'th-has-data-cells', weight: 3, group: 'a11y-tables-lists'}, + {id: 'valid-lang', weight: 3, group: 'a11y-language'}, + {id: 'video-caption', weight: 10, group: 'a11y-audio-video'}, + {id: 'video-description', weight: 10, group: 'a11y-audio-video'}, // Manual audits {id: 'logical-tab-order', weight: 0}, {id: 'focusable-controls', weight: 0}, From 5cfb300e3c8ee7c5a871b9e0e5f4e55432b520b7 Mon Sep 17 00:00:00 2001 From: Rob Dodson Date: Thu, 2 May 2019 22:37:54 -0700 Subject: [PATCH 3/8] Update samples. --- .../test/cli/__snapshots__/index-test.js.snap | 64 +++++++++---------- lighthouse-core/test/results/sample_v2.json | 20 +++--- 2 files changed, 42 insertions(+), 42 deletions(-) diff --git a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap index 23fece289011..e6033bb2d710 100644 --- a/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap +++ b/lighthouse-cli/test/cli/__snapshots__/index-test.js.snap @@ -387,42 +387,42 @@ Object { Object { "group": "a11y-aria", "id": "aria-allowed-attr", - "weight": 3, + "weight": 10, }, Object { "group": "a11y-aria", "id": "aria-required-attr", - "weight": 2, + "weight": 10, }, Object { "group": "a11y-aria", "id": "aria-required-children", - "weight": 5, + "weight": 10, }, Object { "group": "a11y-aria", "id": "aria-required-parent", - "weight": 2, + "weight": 10, }, Object { "group": "a11y-aria", "id": "aria-roles", - "weight": 3, + "weight": 10, }, Object { "group": "a11y-aria", "id": "aria-valid-attr-value", - "weight": 2, + "weight": 10, }, Object { "group": "a11y-aria", "id": "aria-valid-attr", - "weight": 5, + "weight": 10, }, Object { "group": "a11y-audio-video", "id": "audio-caption", - "weight": 4, + "weight": 10, }, Object { "group": "a11y-names-labels", @@ -432,57 +432,57 @@ Object { Object { "group": "a11y-navigation", "id": "bypass", - "weight": 10, + "weight": 3, }, Object { "group": "a11y-color-contrast", "id": "color-contrast", - "weight": 6, + "weight": 3, }, Object { "group": "a11y-tables-lists", "id": "definition-list", - "weight": 1, + "weight": 3, }, Object { "group": "a11y-tables-lists", "id": "dlitem", - "weight": 1, + "weight": 3, }, Object { "group": "a11y-names-labels", "id": "document-title", - "weight": 2, + "weight": 3, }, Object { "group": "a11y-best-practices", "id": "duplicate-id", - "weight": 5, + "weight": 1, }, Object { "group": "a11y-names-labels", "id": "frame-title", - "weight": 5, + "weight": 3, }, Object { "group": "a11y-language", "id": "html-has-lang", - "weight": 4, + "weight": 3, }, Object { "group": "a11y-language", "id": "html-lang-valid", - "weight": 1, + "weight": 3, }, Object { "group": "a11y-names-labels", "id": "image-alt", - "weight": 8, + "weight": 10, }, Object { "group": "a11y-names-labels", "id": "input-image-alt", - "weight": 1, + "weight": 10, }, Object { "group": "a11y-names-labels", @@ -492,67 +492,67 @@ Object { Object { "group": "a11y-tables-lists", "id": "layout-table", - "weight": 1, + "weight": 3, }, Object { "group": "a11y-names-labels", "id": "link-name", - "weight": 9, + "weight": 3, }, Object { "group": "a11y-tables-lists", "id": "list", - "weight": 5, + "weight": 3, }, Object { "group": "a11y-tables-lists", "id": "listitem", - "weight": 4, + "weight": 3, }, Object { "group": "a11y-best-practices", "id": "meta-refresh", - "weight": 1, + "weight": 10, }, Object { "group": "a11y-best-practices", "id": "meta-viewport", - "weight": 3, + "weight": 10, }, Object { "group": "a11y-names-labels", "id": "object-alt", - "weight": 4, + "weight": 3, }, Object { "group": "a11y-navigation", "id": "tabindex", - "weight": 4, + "weight": 3, }, Object { "group": "a11y-tables-lists", "id": "td-headers-attr", - "weight": 1, + "weight": 3, }, Object { "group": "a11y-tables-lists", "id": "th-has-data-cells", - "weight": 1, + "weight": 3, }, Object { "group": "a11y-language", "id": "valid-lang", - "weight": 1, + "weight": 3, }, Object { "group": "a11y-audio-video", "id": "video-caption", - "weight": 4, + "weight": 10, }, Object { "group": "a11y-audio-video", "id": "video-description", - "weight": 3, + "weight": 10, }, Object { "id": "logical-tab-order", diff --git a/lighthouse-core/test/results/sample_v2.json b/lighthouse-core/test/results/sample_v2.json index 97d3bf034daf..ada4c2fae507 100644 --- a/lighthouse-core/test/results/sample_v2.json +++ b/lighthouse-core/test/results/sample_v2.json @@ -3298,12 +3298,12 @@ }, { "id": "bypass", - "weight": 10, + "weight": 3, "group": "a11y-navigation" }, { "id": "color-contrast", - "weight": 6, + "weight": 3, "group": "a11y-color-contrast" }, { @@ -3318,12 +3318,12 @@ }, { "id": "document-title", - "weight": 2, + "weight": 3, "group": "a11y-names-labels" }, { "id": "duplicate-id", - "weight": 5, + "weight": 1, "group": "a11y-best-practices" }, { @@ -3333,7 +3333,7 @@ }, { "id": "html-has-lang", - "weight": 4, + "weight": 3, "group": "a11y-language" }, { @@ -3343,7 +3343,7 @@ }, { "id": "image-alt", - "weight": 8, + "weight": 10, "group": "a11y-names-labels" }, { @@ -3363,7 +3363,7 @@ }, { "id": "link-name", - "weight": 9, + "weight": 3, "group": "a11y-names-labels" }, { @@ -3383,12 +3383,12 @@ }, { "id": "meta-viewport", - "weight": 3, + "weight": 10, "group": "a11y-best-practices" }, { "id": "object-alt", - "weight": 4, + "weight": 3, "group": "a11y-names-labels" }, { @@ -3467,7 +3467,7 @@ } ], "id": "accessibility", - "score": 0.36 + "score": 0.38 }, "best-practices": { "title": "Best Practices", From 4d58b890acfb60da96394a4d0c017196805942ab Mon Sep 17 00:00:00 2001 From: Rob Dodson Date: Fri, 3 May 2019 07:30:36 -0700 Subject: [PATCH 4/8] Update samples. --- proto/sample_v2_round_trip.json | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/proto/sample_v2_round_trip.json b/proto/sample_v2_round_trip.json index 876a2dd980e1..1af6af0d7551 100644 --- a/proto/sample_v2_round_trip.json +++ b/proto/sample_v2_round_trip.json @@ -3050,12 +3050,12 @@ { "group": "a11y-navigation", "id": "bypass", - "weight": 10.0 + "weight": 3.0 }, { "group": "a11y-color-contrast", "id": "color-contrast", - "weight": 6.0 + "weight": 3.0 }, { "group": "a11y-tables-lists", @@ -3070,12 +3070,12 @@ { "group": "a11y-names-labels", "id": "document-title", - "weight": 2.0 + "weight": 3.0 }, { "group": "a11y-best-practices", "id": "duplicate-id", - "weight": 5.0 + "weight": 1.0 }, { "group": "a11y-names-labels", @@ -3085,7 +3085,7 @@ { "group": "a11y-language", "id": "html-has-lang", - "weight": 4.0 + "weight": 3.0 }, { "group": "a11y-language", @@ -3095,7 +3095,7 @@ { "group": "a11y-names-labels", "id": "image-alt", - "weight": 8.0 + "weight": 10.0 }, { "group": "a11y-names-labels", @@ -3115,7 +3115,7 @@ { "group": "a11y-names-labels", "id": "link-name", - "weight": 9.0 + "weight": 3.0 }, { "group": "a11y-tables-lists", @@ -3135,12 +3135,12 @@ { "group": "a11y-best-practices", "id": "meta-viewport", - "weight": 3.0 + "weight": 10.0 }, { "group": "a11y-names-labels", "id": "object-alt", - "weight": 4.0 + "weight": 3.0 }, { "group": "a11y-navigation", @@ -3220,7 +3220,7 @@ "description": "These checks highlight opportunities to [improve the accessibility of your web app](https://developers.google.com/web/fundamentals/accessibility). Only a subset of accessibility issues can be automatically detected so manual testing is also encouraged.", "id": "accessibility", "manualDescription": "These items address areas which an automated testing tool cannot cover. Learn more in our guide on [conducting an accessibility review](https://developers.google.com/web/fundamentals/accessibility/how-to-review).", - "score": 0.36, + "score": 0.38, "title": "Accessibility" }, "best-practices": { From 37a7c613bfc107902778f69f6caa782158d20a2c Mon Sep 17 00:00:00 2001 From: Rob Dodson Date: Fri, 3 May 2019 07:39:32 -0700 Subject: [PATCH 5/8] Fix failing category test. --- .../test/report/html/renderer/category-renderer-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lighthouse-core/test/report/html/renderer/category-renderer-test.js b/lighthouse-core/test/report/html/renderer/category-renderer-test.js index 6ac2722b5299..8e691f5a5862 100644 --- a/lighthouse-core/test/report/html/renderer/category-renderer-test.js +++ b/lighthouse-core/test/report/html/renderer/category-renderer-test.js @@ -243,7 +243,7 @@ describe('CategoryRenderer', () => { const categoryDOM = renderer.render(category, sampleResults.categoryGroups); const gauge = categoryDOM.querySelector('.lh-gauge__percentage'); - assert.equal(gauge.textContent.trim(), '36', 'score is 0-100'); + assert.equal(gauge.textContent.trim(), '38', 'score is 0-100'); const score = categoryDOM.querySelector('.lh-category-header'); const value = categoryDOM.querySelector('.lh-gauge__percentage'); From 5cae4fbabf969c4265c78f4735f6742b11788677 Mon Sep 17 00:00:00 2001 From: Rob Dodson Date: Fri, 3 May 2019 10:59:53 -0700 Subject: [PATCH 6/8] Add audit comment. --- lighthouse-core/config/default-config.js | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js index b59f942e2f3c..3adc40ad63fd 100644 --- a/lighthouse-core/config/default-config.js +++ b/lighthouse-core/config/default-config.js @@ -79,7 +79,8 @@ const UIStrings = { seoCategoryManualDescription: 'Run these additional validators on your site to check additional SEO best practices.', /* Title of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight opportunities to make a page more usable on mobile devices. */ seoMobileGroupTitle: 'Mobile Friendly', - /* Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight opportunities to make a page more usable on mobile devices. */ + /* Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are + with descriptive titles that highlight opportunities to make a page more usable on mobile devices. */ seoMobileGroupDescription: 'Make sure your pages are mobile friendly so users don’t have to pinch or zoom ' + 'in order to read the content pages. [Learn more](https://developers.google.com/search/mobile-sites/).', /* Title of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website content more easily understood by search engine crawler bots. */ @@ -395,6 +396,10 @@ const defaultConfig = { title: str_(UIStrings.a11yCategoryTitle), description: str_(UIStrings.a11yCategoryDescription), manualDescription: str_(UIStrings.a11yCategoryManualDescription), + // Audit weights are meant to match the aXe scoring system of + // minor, serious, and critical. + // See the audits listed at dequeuniversity.com/rules/axe/3.2. + // Click on an audit and check the right hand column to see its severity. auditRefs: [ {id: 'accesskeys', weight: 3, group: 'a11y-navigation'}, {id: 'aria-allowed-attr', weight: 10, group: 'a11y-aria'}, From 04674d43d9a55db4c4f4f343e2e731c4e2a4695e Mon Sep 17 00:00:00 2001 From: Brendan Kenny Date: Fri, 3 May 2019 11:51:34 -0700 Subject: [PATCH 7/8] bad \n, bad --- lighthouse-core/config/default-config.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js index 3adc40ad63fd..bde22bed7897 100644 --- a/lighthouse-core/config/default-config.js +++ b/lighthouse-core/config/default-config.js @@ -79,8 +79,7 @@ const UIStrings = { seoCategoryManualDescription: 'Run these additional validators on your site to check additional SEO best practices.', /* Title of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight opportunities to make a page more usable on mobile devices. */ seoMobileGroupTitle: 'Mobile Friendly', - /* Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are - with descriptive titles that highlight opportunities to make a page more usable on mobile devices. */ + /* Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are with descriptive titles that highlight opportunities to make a page more usable on mobile devices. */ seoMobileGroupDescription: 'Make sure your pages are mobile friendly so users don’t have to pinch or zoom ' + 'in order to read the content pages. [Learn more](https://developers.google.com/search/mobile-sites/).', /* Title of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website content more easily understood by search engine crawler bots. */ From 925a59a4ca66dbc81b7c52183b7ca4e9796549d7 Mon Sep 17 00:00:00 2001 From: Brendan Kenny Date: Fri, 3 May 2019 11:52:27 -0700 Subject: [PATCH 8/8] bad brendan, bad --- lighthouse-core/config/default-config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lighthouse-core/config/default-config.js b/lighthouse-core/config/default-config.js index bde22bed7897..f896cd423fb9 100644 --- a/lighthouse-core/config/default-config.js +++ b/lighthouse-core/config/default-config.js @@ -79,7 +79,7 @@ const UIStrings = { seoCategoryManualDescription: 'Run these additional validators on your site to check additional SEO best practices.', /* Title of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight opportunities to make a page more usable on mobile devices. */ seoMobileGroupTitle: 'Mobile Friendly', - /* Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are with descriptive titles that highlight opportunities to make a page more usable on mobile devices. */ + /* Description of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight opportunities to make a page more usable on mobile devices. */ seoMobileGroupDescription: 'Make sure your pages are mobile friendly so users don’t have to pinch or zoom ' + 'in order to read the content pages. [Learn more](https://developers.google.com/search/mobile-sites/).', /* Title of the navigation section within the Search Engine Optimization (SEO) category. Within this section are audits with descriptive titles that highlight ways to make a website content more easily understood by search engine crawler bots. */