Enable device emulation, network throttling, and disable disk cache. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }; | ||
|
|
||
| const DEVICE_EMULATION_USERAGENT = { |
There was a problem hiding this comment.
is there going to be a good way to keep this in sync with shipping Chrome?
There was a problem hiding this comment.
I hope so, though devtools project hasnt found a good way, yet. :)
For us, we could do something along the lines of pinging the omahaproxy API every week
|
review? |
|
you'll have to fix your merge conflicts |
|
fixed |
| emulation.enableNexus5X(this); | ||
| emulation.enableNetworkThrottling(this); | ||
| emulation.disableCache(this); | ||
| this.pendingCommandsComplete().then(_ => resolve()); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the specs from #33.
Device
Network
This PR depends on #88, so here's a cleaner diff between the two:
paulirish/lighthouse@paulirish:cri-encapsulate...emulation
Also now that all this works, we can load m.flipkart successfully, so I've switched the default to that. Results are already interesting. :)