Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Puppeteer consider visible element as not visible #4281

Closed
Kalliser opened this issue Apr 13, 2019 · 3 comments

Comments

Projects
None yet
2 participants
@Kalliser
Copy link

commented Apr 13, 2019

Hello I have a similar issue than the one you previously corrected in ticket #4274 but this one is still present even with last version of master branch of puppeteer

Steps to reproduce

Tell us about your environment:

  • Puppeteer version: master branch ( 8f8e774 )
  • Platform / OS version: Debian (Dockerized in node:10-stretch-slim)
  • URLs (if applicable): https://www.edistat.com/
  • Node.js version: v10.15.1

What steps will reproduce the problem?

Open the website
Click on .list-group .list-group-item:nth-of-type(1) .gotodetail
Wait for the url https://www.edistat.com/livre_tarifs.php?ean=9782702165485

Please include code that reproduces the issue.
Note 1 : this code sample works fine until 1.5.0 of puppeteer and below

const browser = await puppeteer.launch();

const page = await browser.newPage();
await page.goto('https://www.edistat.com/');

await Promise.all([
  page.click('.list-group .list-group-item:nth-of-type(1) .gotodetail'),
  page.waitForNavigation({waitUntil: ['networkidle0', 'load', 'domcontentloaded'], timeout: 30000})
]);
console.log(await page.url());
await page.screenshot({path: 'screenshot.png', fullPage: true});

await browser.close();

What is the expected result?
The page https://www.edistat.com/livre_tarifs.php?ean=9782702165485 should be opened when clicking on .list-group .list-group-item:nth-of-type(1) .gotodetail

What happens instead?
Browser is stuck on homepage with the message

Error running your code. Error: Node is either not visible or not an HTMLElement

@aslushnikov

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

@Kalliser nice, thank you for reporting this. This is upstream bug, filed as https://crbug.com/952562

Upstream fix is out for a review: https://chromium-review.googlesource.com/c/chromium/src/+/1564937

aslushnikov added a commit that referenced this issue Apr 13, 2019

aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Apr 13, 2019

feat(chromium): roll Chromium to r650583
This roll includes:
- https://crrev.com/650583 - DevTools: fix DOM.getContentQuads for a
  corner case

Fixes GoogleChrome#4281.

aslushnikov added a commit that referenced this issue Apr 13, 2019

feat(chromium): roll Chromium to r650583 (#4284)
This roll includes:
- https://crrev.com/650583 - DevTools: fix DOM.getContentQuads for a
  corner case

Fixes #4281.
@aslushnikov

This comment has been minimized.

Copy link
Contributor

commented Apr 13, 2019

@Kalliser the fix has landed and is published at puppeteer@next.

@Kalliser

This comment has been minimized.

Copy link
Author

commented Apr 13, 2019

@aslushnikov Thank you very much I confirm you that it now working on my side.

I stay aware if another bug appear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.