Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What's going on with Chromium size, it has grown three times in the latest minor release (1.17.0 -> 1.18.0) #4610

Closed
limonte opened this issue Jun 21, 2019 · 8 comments

Comments

@limonte
Copy link

commented Jun 21, 2019

I'm trying to install puppeteer on Linux and was shocked by the Chromium size:

npm i puppeteer@1.17.0

Downloading Chromium r662092 - **111.6 Mb**
npm i puppeteer@1.18.0

Downloading Chromium r669486 - **347.1 Mb**

Is Chromium growing so rapidly or is it a bug?

@limonte limonte changed the title What's going on with Chromium size, it has grown three times since 1.0.0 What's going on with Chromium size, it has grown three times in the latest minor release (1.17.0 -> 1.18.0) Jun 21, 2019

@sudofox

This comment has been minimized.

Copy link

commented Jun 21, 2019

Yeah, I was wondering the same thing. Redeploying something using Puppeteer and Chromium is now over one-third of a GB in size

@aslushnikov

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2019

Whoa, that's a bug!

@aslushnikov

This comment has been minimized.

Copy link
Collaborator

commented Jun 21, 2019

@limonte

This comment has been minimized.

Copy link
Author

commented Jun 22, 2019

Thank you @aslushnikov!

As I can see the reported issue is already fixed.


I have an offtopic question: since you work in Google do you maybe know why isn't Chromium repo on Github? I mean GitHub is the "default" place to collaborate on software. The current UI for Chromium's bug-tracker looks terrible (in my eyes) and I personally can't figure out what's happening with repo and therefore can't contribute.

@stevenvachon

This comment has been minimized.

Copy link

commented Jun 24, 2019

It's been running Travis CI out of memory too. Reverting to 1.17.0 fixes it.

@econner

This comment has been minimized.

Copy link

commented Jun 25, 2019

It also is causing slug sizes on Heroku to be too large if you run puppeteer there. Confirm that reverting to 1.17.0 also fixes it.

aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Jun 25, 2019

feat(chromium): roll Chromium to r672088
This roll includes:
- https://crrev.com/671499 - Build with symbol_level=0 for linux-archive-rel

Fix GoogleChrome#4610

aslushnikov added a commit to aslushnikov/puppeteer that referenced this issue Jun 25, 2019

feat(chromium): roll Chromium to r672088
This roll includes:
- https://crrev.com/671499 - Build with symbol_level=0 for linux-archive-rel

Fix GoogleChrome#4610

aslushnikov added a commit that referenced this issue Jun 26, 2019

feat(chromium): roll Chromium to r672088 (#4626)
This roll includes:
- https://crrev.com/671499 - Build with symbol_level=0 for linux-archive-rel

Fix #4610
@wavded

This comment has been minimized.

Copy link

commented Jun 26, 2019

Same issue, reverting to 1.17.0 fixed it for me too.

@aslushnikov

This comment has been minimized.

Copy link
Collaborator

commented Jun 26, 2019

We released v1.18.1 with the fix for the bug.

Sorry for this regression!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.