Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(page): respect timeout 0 in page.waitForFunction #2563

Merged
merged 2 commits into from May 25, 2018

Conversation

Projects
None yet
2 participants
@aslushnikov
Copy link
Contributor

commented May 17, 2018

The in-page task should not set timeout when timeout is 0.

Fixes #2540.

fix(Page): respect timeout 0 in page.waitForFunction
The in-page task should not set timeout when timeout is 0.

Fixes #2540.

@aslushnikov aslushnikov requested a review from JoelEinbinder May 17, 2018

window.__counter = (window.__counter || 0) + 1;
return window.__injected;
}, {timeout: 0, polling: 10});
await page.waitFor(100);

This comment has been minimized.

Copy link
@JoelEinbinder

JoelEinbinder May 17, 2018

Collaborator

have another wait for function that waits for counter.

This comment has been minimized.

Copy link
@aslushnikov

aslushnikov May 25, 2018

Author Contributor

Done.

@aslushnikov aslushnikov changed the title fix(Page): respect timeout 0 in page.waitForFunction fix(page): respect timeout 0 in page.waitForFunction May 25, 2018

@aslushnikov aslushnikov merged commit debfe7e into GoogleChrome:master May 25, 2018

6 of 8 checks passed

node6 (windows)
Details
node7 (windows)
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
node6 (linux)
Details
node7 (linux)
Details
pr title lint PR title is good to go, boss
Details

@aslushnikov aslushnikov deleted the aslushnikov:fix-predicate branch Aug 1, 2018

LarenDorr added a commit to LarenDorr/puppeteer that referenced this pull request Mar 19, 2019

fix(page): respect timeout 0 in page.waitForFunction (GoogleChrome#2563)
The in-page task should not set timeout when timeout is 0.

Fixes GoogleChrome#2540.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.