New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(request): extend error reasons based on missing values from spec #2771
fix(request): extend error reasons based on missing values from spec #2771
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
@googlebot Signed it. |
CLAs look good, thanks! |
@@ -506,6 +506,8 @@ const errorReasons = { | |||
'aborted': 'Aborted', | |||
'accessdenied': 'AccessDenied', | |||
'addressunreachable': 'AddressUnreachable', | |||
'blockedbyclient': 'BlockedByClient', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you please update documentation for the request.abort
method in docs/api.md
:
https://github.com/GoogleChrome/puppeteer/blob/master/docs/api.md#requestaborterrorcode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aslushnikov Sure. Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
As the title indicated, adds two allowed error codes that are specified in the Chrome Developer Tools Protocol specifications but missing from the Puppeteer enum:
https://chromedevtools.github.io/devtools-protocol/tot/Network#type-ErrorReason