Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(networkmanager): Remove header 'cookie' from request hash #2954

Merged
merged 1 commit into from Jul 31, 2018

Conversation

Projects
None yet
3 participants
@DonoA
Copy link
Contributor

commented Jul 25, 2018

This fixes an issue in which a response may not be recorded or trigger an event because of differing cookie headers from the request.

I didn't see anywhere to add testing for this functionality, however if you would like tests added, just point me in the right direction.

fix(NetworkManager): Remove header 'cookie' from request hash
This fixes an issue in which a response may not be recorded or trigger an event because of differing cookie headers from the request.
@googlebot

This comment has been minimized.

Copy link

commented Jul 25, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@DonoA DonoA changed the title fix(NetworkManager): Remove header 'cookie' from request hash fix(networkmanager): Remove header 'cookie' from request hash Jul 25, 2018

@DonoA

This comment has been minimized.

Copy link
Contributor Author

commented Jul 25, 2018

I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Jul 25, 2018

CLAs look good, thanks!

@aslushnikov
Copy link
Contributor

left a comment

Thanks. I'll add a test for this in a follow-up.

@aslushnikov aslushnikov merged commit 0b12119 into GoogleChrome:master Jul 31, 2018

6 of 7 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
cla/google All necessary CLAs are signed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
node6 (linux)
Details
node7 (linux)
Details
node8 (macOS)
Details
pr title lint PR title is good to go, boss
Details

aslushnikov added a commit to aslushnikov/puppeteer that referenced this pull request Aug 1, 2018

fix(NetworkManager): Remove header 'cookie' from request hash (Google…
…Chrome#2954)

This fixes an issue in which a response may not be recorded or trigger an event because of differing cookie headers from the request.

References GoogleChrome#2970

LarenDorr added a commit to LarenDorr/puppeteer that referenced this pull request Mar 19, 2019

fix(NetworkManager): Remove header 'cookie' from request hash (Google…
…Chrome#2954)

This fixes an issue in which a response may not be recorded or trigger an event because of differing cookie headers from the request.

References GoogleChrome#2970
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.