Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(troubleshooting.md): run non-headless on CI #3353

Merged
merged 2 commits into from Oct 9, 2018

Conversation

Projects
None yet
4 participants
@restrry
Copy link
Contributor

commented Oct 5, 2018

related issue: #3303

@googlebot

This comment has been minimized.

Copy link

commented Oct 5, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@restrry restrry force-pushed the restrry:run-non-headless-on-ci branch from bd2af03 to 4044e3a Oct 5, 2018

@restrry restrry changed the title add a doc how to run non-headless on CI docs(troubleshooting.md): run non-headless on CI Oct 5, 2018

@aslushnikov

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2018

@restrry can you please sign a CLA to make our bot happy?

@restrry

This comment has been minimized.

Copy link
Contributor Author

commented Oct 5, 2018

@aslushnikov done!

@googlebot

This comment has been minimized.

Copy link

commented Oct 5, 2018

CLAs look good, thanks!

Show resolved Hide resolved docs/troubleshooting.md Outdated

@restrry restrry force-pushed the restrry:run-non-headless-on-ci branch from 4044e3a to 9087434 Oct 7, 2018

@aslushnikov aslushnikov merged commit a04dedc into GoogleChrome:master Oct 9, 2018

6 of 7 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
node6 (linux) Task Summary
Details
node8 (linux) Task Summary
Details
node8 (macOS) Task Summary
Details
pr title lint PR title is good to go, boss
Details

LarenDorr added a commit to LarenDorr/puppeteer that referenced this pull request Mar 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.