Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csscoverage): don't prematurely disable the CSS domain #3418

Merged
merged 1 commit into from Oct 16, 2018

Conversation

JoelEinbinder
Copy link
Collaborator

@JoelEinbinder JoelEinbinder commented Oct 16, 2018

CSS stylesheets can still be parsed and added events emitted during the CSS.stopRuleUsageTracking call. It needs to be awaited before calling CSS.disable, otherwise the text content of those style sheets will be unavailable.

@aslushnikov aslushnikov merged commit d025d1f into puppeteer:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants