Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Make intervention test Edge friendly #4314

Merged
merged 2 commits into from Apr 19, 2019

Conversation

Projects
None yet
2 participants
@kblok
Copy link
Contributor

commented Apr 19, 2019

All tests are green when running against Microsoft Edge Insider, except this test.

Edge returns https://to-be-replaced.invalid/feature/5718547946799104 instead of https://www.chromestatus.com/feature/5718547946799104

I think that checking for feature/5718547946799104 is a small test and will do the job for both browsers.

$env:CHROME = "C:\Program Files (x86)\Microsoft\Edge Dev\Application\msedge.exe"; node
.\test.js

kblok and others added some commits Apr 19, 2019

@aslushnikov
Copy link
Contributor

left a comment

Thanks!

@aslushnikov aslushnikov merged commit dde55b0 into GoogleChrome:master Apr 19, 2019

7 of 8 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
Chromium (node6 + linux) Task Summary
Details
Chromium (node8 + linux) Task Summary
Details
Chromium (node8 + macOS) Task Summary
Details
Firefox (node8 + linux) Task Summary
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
pr title lint PR title is good to go, boss
Details

@kblok kblok deleted the kblok:edge/edge-fix branch Apr 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.