feat(Page): Support Page.getMetrics and metrics event. #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides access to the current page performance metrics. Allows to push page metrics from the page JavaScript with console.timeStamp()
|
Thanks Alexei! Let's list the metric names explicitly so that it's easier to consume. |
aslushnikov
reviewed
Oct 5, 2017
test/test.js
Outdated
| checkMetrics(metrics.metrics); | ||
| })); | ||
| function checkMetrics(metrics) { | ||
| expect(metrics['Timestamp']).toBeGreaterThan(0); |
There was a problem hiding this comment.
can we also check that there are no other fields beyond these? this would allow us to update docs when something new is added
There was a problem hiding this comment.
There are other fields coming over the protocol. But we don't want to document/expose those in puppeteer.
aslushnikov
reviewed
Oct 5, 2017
lib/Page.js
Outdated
| _buildMetricsObject(metrics) { | ||
| const result = {}; | ||
| for (const metric of metrics || []) | ||
| result[metric.name] = metric.value; |
There was a problem hiding this comment.
since we don't want to expose certain numbers, can we white-list properties that we copy (instead of copying everything)?
aslushnikov
approved these changes
Oct 10, 2017
ithinkihaveacat
pushed a commit
to ithinkihaveacat/puppeteer
that referenced
this pull request
Oct 31, 2017
Provides access to the current page performance metrics. Allows to push page metrics from the page JavaScript with console.timeStamp() Fixes puppeteer#309
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides access to the current page performance metrics.
Allows to push page metrics from the page JavaScript with
console.timeStamp()Fixes #309