Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile rendering #234

Merged
merged 1 commit into from Jan 3, 2019

Conversation

Projects
None yet
5 participants
@danielpoonwj
Copy link
Contributor

danielpoonwj commented Nov 3, 2018

Fixes #233.

The page may reload when setting the isMobile property on page.setViewport according to the docs. This can be visually verified when launching puppeteer in non-headless mode - the page rendered is about:blank, resulting in the 400 error.

@danielpoonwj danielpoonwj requested a review from samuelli as a code owner Nov 3, 2018

@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 3, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
@danielpoonwj

This comment has been minimized.

Copy link
Contributor Author

danielpoonwj commented Nov 3, 2018

I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 3, 2018

CLAs look good, thanks!

@pojda

This comment has been minimized.

Copy link

pojda commented Dec 2, 2018

Can anyone review this?

@rajikaimal

This comment has been minimized.

Copy link
Contributor

rajikaimal commented Dec 31, 2018

cc: @samuelli

@samuelli

This comment has been minimized.

Copy link
Member

samuelli commented Jan 3, 2019

cc @AVGP

@samuelli samuelli merged commit e8a2912 into GoogleChrome:master Jan 3, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.