Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always close page before return to prevent memory leak #268

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@ramadimasatria
Copy link

ramadimasatria commented Feb 11, 2019

This PR fixes possible memory leak when renderer returns early after found an error. The page should be closed before every return to avoid a huge pile of unused pages.

@ramadimasatria ramadimasatria requested a review from AVGP as a code owner Feb 11, 2019

@googlebot

This comment has been minimized.

Copy link

googlebot commented Feb 11, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
@ramadimasatria

This comment has been minimized.

Copy link
Author

ramadimasatria commented Feb 11, 2019

I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Feb 11, 2019

CLAs look good, thanks!

@ramadimasatria ramadimasatria changed the title Always close page before return Always close page before return to prevent memory leak Feb 22, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.