Service Worker Video Caching Sample #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jeffposnick ptal when you have a moment. Used by google/WebFundamentals#2906. |
|
The issue right now with serving videos from the SW cache is that seeking doesn't work out of the box. You need to properly handle It would be good to include that technique in this sample, at which point we should be 👍 |
|
Hi @jeffposnick — I've added code to handle range requests. (Apologies for all the commits — had some trouble at first getting site running locally. Not sure why .gitignore file mode has changed :(.) |
|
👍 Thanks, @samdutton! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits can be squashed on merge :).
Not sure why the .gitignore file mode has changed :(.