New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicitly request node v16.14.2 + npm v8.5.0 #7632
Conversation
✅ Deploy Preview for web-dev-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
| @@ -2,19 +2,19 @@ | |||
|
|
|||
| timeout: 2700s # set build timeout to 45 mins | |||
| steps: | |||
| - name: node:16 | |||
| - name: node:16.14.2 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My understanding is that https://hub.docker.com/_/node/ has the list of valid tags to use, including 16.14.2. Explicitly asking for a given version instead of relying on the generic 16 seemed safer.
We obviously should double-check Cloud Build after this PR is merged to confirm.
|
I can confirm that both the Netlify staging build and presubmit GH Action used the intended version of node, so we're good. |
|
Fixes #7619 by ensuring that all our many environments, along with the locally pinned
.nvmrcandvoltaversions, usenodev16.14.2 andnpmv8.5.0.Let's obviously confirm that the staging and presubmit are using the expected versions of
nodeandnpmbefore merging!