Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly request node v16.14.2 + npm v8.5.0 #7632

Merged
merged 2 commits into from Apr 6, 2022
Merged

Conversation

jeffposnick
Copy link
Contributor

Fixes #7619 by ensuring that all our many environments, along with the locally pinned .nvmrc and volta versions, use node v16.14.2 and npm v8.5.0.

Let's obviously confirm that the staging and presubmit are using the expected versions of node and npm before merging!

@jeffposnick jeffposnick requested a review from a team as a code owner April 1, 2022 20:21
@netlify
Copy link

netlify bot commented Apr 1, 2022

Deploy Preview for web-dev-staging ready!

Name Link
🔨 Latest commit 4d6cb77
🔍 Latest deploy log https://app.netlify.com/sites/web-dev-staging/deploys/62475ec9c2334a000cd27235
😎 Deploy Preview https://deploy-preview-7632--web-dev-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@@ -2,19 +2,19 @@

timeout: 2700s # set build timeout to 45 mins
steps:
- name: node:16
- name: node:16.14.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My understanding is that https://hub.docker.com/_/node/ has the list of valid tags to use, including 16.14.2. Explicitly asking for a given version instead of relying on the generic 16 seemed safer.

We obviously should double-check Cloud Build after this PR is merged to confirm.

@jeffposnick jeffposnick added the $-presubmit Add label to run presubmit tests. label Apr 1, 2022
@github-actions github-actions bot removed the $-presubmit Add label to run presubmit tests. label Apr 1, 2022
@jeffposnick
Copy link
Contributor Author

I can confirm that both the Netlify staging build and presubmit GH Action used the intended version of node, so we're good.

@jeffposnick jeffposnick merged commit ae06c50 into main Apr 6, 2022
@jeffposnick jeffposnick deleted the bump-node-versions branch April 6, 2022 14:22
@thanhtrieu502
Copy link

Sửa lỗi # 7619.nvmrc bằng cách đảm bảo rằng tất cả nhiều môi trường của chúng tôi, cùng với các phiên bản và voltaphiên bản được ghim cục bộ , sử dụng nodev16.14.2 và npmv8.5.0.

Hãy xác nhận rõ ràng rằng phần tổ chức và phần gửi trước đang sử dụng các phiên bản dự kiến ​​của nodenpmtrước khi hợp nhất!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package-lock.json mismatches are not caught by presubmit
3 participants