Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in Workbox Strategies documentation ( "{f" -> "{" ) #2367

Closed
drytt opened this issue Feb 13, 2020 · 1 comment
Closed

Typo in Workbox Strategies documentation ( "{f" -> "{" ) #2367

drytt opened this issue Feb 13, 2020 · 1 comment

Comments

@drytt
Copy link

@drytt drytt commented Feb 13, 2020

Library Affected:
Workbox Strategies (documentation)

Browser & Platform:
all browsers

Issue or Feature Request Description:
I think there are unnecessary characters f left.

Workbox Strategies > Advanced Usage
(https://developers.google.com/web/tools/workbox/modules/workbox-strategies)

AS-IS:

...
  if (url.origin === location.origin && url.pathname === '/') {f
...

TO-BE:

...
  if (url.origin === location.origin && url.pathname === '/') {
...
@jeffposnick

This comment has been minimized.

Copy link
Collaborator

@jeffposnick jeffposnick commented Feb 13, 2020

Thanks for pointing this out. (I blame my Macbook Pro's keyboard...)

It'll be addressed in google/WebFundamentals#8474

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.