Ensure workbox is available before referencing it#2007
Merged
jeffposnick merged 1 commit intoGoogleChrome:masterfrom Apr 3, 2019
Merged
Ensure workbox is available before referencing it#2007jeffposnick merged 1 commit intoGoogleChrome:masterfrom
jeffposnick merged 1 commit intoGoogleChrome:masterfrom
Conversation
jeffposnick
approved these changes
Apr 3, 2019
Contributor
jeffposnick
left a comment
jeffposnick
left a comment
There was a problem hiding this comment.
Thanks for catching this—unfortunately, it's a blind spot for our workbox-build test suite, which runs the generated SW code in an environment that has all of the workbox.* methods stubbed out.
|
Hey @jeffposnick any ETA on a new minor version release? We'd love to start utilizing this 🕺 |
Contributor
|
We just pushed out |
|
I can't find this in v5.0.0, how can i use it? |
This was referenced Jan 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R: @jeffposnick @philipwalton
Fixes #1915 / #1981
Sorry to follow up with a PR immediately after the publish, but it turns out order in the template does matter, as otherwise
workboxmight not be defined yet (total facepalm on my part)! I feel like I probably missed implementing a test somewhere in the initial pass but I'm not sure where that should've gone, so I at least added a warning comment for now. Let me know if there's something better I could add.