Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show some flexbox labels #36

Open
argyleink opened this issue Aug 16, 2018 · 8 comments

Comments

@argyleink
Copy link
Collaborator

commented Aug 16, 2018

at least indicate if it's a flex container

@argyleink argyleink added this to To do in v1 Aug 16, 2018

@argyleink argyleink moved this from To do to In progress in v1 Aug 21, 2018

@argyleink argyleink moved this from In progress to To do in v1 Aug 30, 2018

@pewstiepoll

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

Hi @argyleink,
I would really like to contribute to the VisBug project! Mind if I try to help with this one?

@argyleink

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 12, 2019

yay, do it 👍

i imagined using this component, which is used like this.

You'll also want to update the flexbox tools strategy for getting the currently selected items, right now it's lazy, and you'll want proactive in order to display a label on selection. You can steal that work from here.

pr will tell a story like:

  • while flexbox tool is active
  • when user makes a selection, align tool looks at the container(s) and determines if they're flex containers or not
  • if a flex container is found, create a label

maybe some tests to write or def things to be aware of while testing manually:

  • ensure label position stays during edits
  • ensure label is removed when the tool is switched or nodes are removed/moved

ping again if you need anything!

@pewstiepoll

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

@argyleink please checkout the PR here: #374

adhrinae pushed a commit to adhrinae/ProjectVisBug that referenced this issue Aug 18, 2019
adhrinae added a commit to adhrinae/ProjectVisBug that referenced this issue Aug 18, 2019
@adhrinae

This comment has been minimized.

Copy link
Contributor

commented Aug 18, 2019

Ooops I was trying to make a PR but too late for this 😂
(and now I realized that I missed some points for this issue)

@argyleink argyleink moved this from To do 🤞 to In progress 😎 in v1 Aug 19, 2019

argyleink added a commit that referenced this issue Aug 22, 2019
Display container layout in Alignment tool (#36) (#374)
* Notify watchers before drawing overlay meta ui.
Custom label defined by currently selected tool.

* Show display value for currently selected element.
Refactoring.

* Correct function naming

* Cleaning up HoFs. Back to chain pattern.

* Return el from `assignLabel` method
@argyleink

This comment has been minimized.

Copy link
Collaborator Author

commented Aug 22, 2019

fixed by #374

@argyleink argyleink closed this Aug 22, 2019

argyleink added a commit that referenced this issue Sep 2, 2019

@argyleink argyleink reopened this Sep 2, 2019

@adhrinae

This comment has been minimized.

Copy link
Contributor

commented Sep 8, 2019

is there a reason why this issue reopened?

@argyleink

This comment has been minimized.

Copy link
Collaborator Author

commented Sep 9, 2019

yeah, the PR merged that resolved this ticket was reverted due to it breaking margin/padding tools. so the task is back open, or just pending a resolution to the PR bug!

@adhrinae

This comment has been minimized.

Copy link
Contributor

commented Sep 9, 2019

Ah, I've just read the PR again and figured out what happened. My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.