Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hoist local style modifications in the MetaTip #378

Merged

Conversation

@adhrinae
Copy link
Contributor

commented Aug 26, 2019

Resolve #311

Description

I've changed DOM structure of metatip.element.js and related CSS styles for a bit.
It should be looked like this.

Screen Shot 2019-08-26 at 22 22 10

Consideration

I wonder whether the user can distinguish between local style modifications and computed styles easily.

@googlebot

This comment has been minimized.

Copy link

commented Aug 26, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@adhrinae

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

@googlebot I signed it!

@googlebot

This comment has been minimized.

Copy link

commented Aug 26, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@argyleink

This comment has been minimized.

Copy link
Collaborator

commented Aug 26, 2019

hi adhinae!

nice work, deployed it here for preview, QA and play: https://promote-modifications.glitch.me

nice PR, your code looks great, you did what the ticket asked 👍

@argyleink argyleink merged commit 8cef53c into GoogleChromeLabs:master Aug 26, 2019

2 checks passed

cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@adhrinae adhrinae deleted the adhrinae:hoist-local-modifications branch Aug 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.