Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ID for grace period dfn to link to from web UI #303

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
5 participants
@tantek
Copy link

tantek commented Jun 5, 2018

No description provided.

@googlebot

This comment has been minimized.

Copy link

googlebot commented Jun 5, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 5, 2018

Codecov Report

Merging #303 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #303   +/-   ##
=======================================
  Coverage   62.35%   62.35%           
=======================================
  Files          50       50           
  Lines        2850     2850           
  Branches      173      173           
=======================================
  Hits         1777     1777           
  Misses       1073     1073

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec8bace...077cd31. Read the comment docs.

@mdittmer

This comment has been minimized.

Copy link
Collaborator

mdittmer commented Jun 11, 2018

Thanks for the contribution, @tantek! Could we get IDs for all the definitions for consistency?

@foolip

This comment has been minimized.

Copy link
Collaborator

foolip commented Feb 15, 2019

@tantek I'll be happy to merge this if it's still something you want to link to. Did you sign the CLA?

@foolip foolip closed this Apr 18, 2019

@foolip

This comment has been minimized.

Copy link
Collaborator

foolip commented Apr 18, 2019

@tantek closing since I didn't hear back, but I'm now maintaining this project so let me know if you want to get this landed, or if there's anything else I can do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.