Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct routes for unstyled and built variants #18

Merged
merged 1 commit into from Oct 24, 2019

Conversation

@Zarthus
Copy link
Contributor

Zarthus commented Oct 24, 2019

An absolute URL leads to a 404 because the full route includes /dark-mode-toggle/

Demo: https://zarthus.github.io/dark-mode-toggle/demo/

An absolute URL leads to a 404 because the full route includes /dark-mode-toggle/
@googlebot

This comment has been minimized.

Copy link

googlebot commented Oct 24, 2019

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@Zarthus

This comment has been minimized.

Copy link
Contributor Author

Zarthus commented Oct 24, 2019

@googlebot I signed it!

@googlebot

This comment has been minimized.

Copy link

googlebot commented Oct 24, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@tomayac tomayac merged commit 1fbe612 into GoogleChromeLabs:master Oct 24, 2019
1 check passed
1 check passed
cla/google All necessary CLAs are signed
@tomayac

This comment has been minimized.

Copy link
Collaborator

tomayac commented Oct 24, 2019

Good catch, thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.