New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lighthouse score fails to score HTTPS properly #204

Closed
juliantoledo opened this Issue Sep 30, 2016 · 16 comments

Comments

Projects
None yet
4 participants
@juliantoledo
Collaborator

juliantoledo commented Sep 30, 2016

At the moment our Lighthouse score fails to score HTTPS properly, the reason is that we are using a server side version of Lighthouse called Moonlight that has a bug on the HTTPS scoring.

We are working with the Lighthouse team to solve it soon.

@juliantoledo juliantoledo added the bug label Sep 30, 2016

@juliantoledo juliantoledo added this to the v1.0 - I'm a PWA!! milestone Oct 3, 2016

@x1ddos

This comment has been minimized.

Show comment
Hide comment
@x1ddos

x1ddos Oct 4, 2016

Collaborator

@juliantoledo can you assign this to me? I'm working on updating server-side version. Hopefully it'll fix the issue.

Collaborator

x1ddos commented Oct 4, 2016

@juliantoledo can you assign this to me? I'm working on updating server-side version. Hopefully it'll fix the issue.

@juliantoledo

This comment has been minimized.

Show comment
Hide comment
@juliantoledo

juliantoledo Oct 4, 2016

Collaborator

Sure @x1ddos, thank you!

Collaborator

juliantoledo commented Oct 4, 2016

Sure @x1ddos, thank you!

@x1ddos

This comment has been minimized.

Show comment
Hide comment
@x1ddos

x1ddos Oct 5, 2016

Collaborator

It feels like an issue with headless chrome after all.
I posted a question to headless-dev: https://groups.google.com/a/chromium.org/d/topic/headless-dev/RqxZAsYra0Y/discussion

Collaborator

x1ddos commented Oct 5, 2016

It feels like an issue with headless chrome after all.
I posted a question to headless-dev: https://groups.google.com/a/chromium.org/d/topic/headless-dev/RqxZAsYra0Y/discussion

@adewale

This comment has been minimized.

Show comment
Hide comment
@abdonrd

This comment has been minimized.

Show comment
Hide comment
@abdonrd

abdonrd Nov 24, 2016

Any news?

abdonrd commented Nov 24, 2016

Any news?

@x1ddos

This comment has been minimized.

Show comment
Hide comment
@x1ddos

x1ddos Nov 24, 2016

Collaborator

@abdonrd The underlying issue has been finally resolved a few days ago. I will pull in the changes and see whether it fixes this bug.

Will update this thread soon.

Collaborator

x1ddos commented Nov 24, 2016

@abdonrd The underlying issue has been finally resolved a few days ago. I will pull in the changes and see whether it fixes this bug.

Will update this thread soon.

@abdonrd

This comment has been minimized.

Show comment
Hide comment
@abdonrd

abdonrd Nov 24, 2016

Nice! Thanks @x1ddos!

abdonrd commented Nov 24, 2016

Nice! Thanks @x1ddos!

@x1ddos

This comment has been minimized.

Show comment
Hide comment
@x1ddos

x1ddos Nov 29, 2016

Collaborator

Good news, https://airhorner.com/ now scores 97/100 on moonlight and has passes HTTPS checks:

image

Collaborator

x1ddos commented Nov 29, 2016

Good news, https://airhorner.com/ now scores 97/100 on moonlight and has passes HTTPS checks:

image

@x1ddos x1ddos closed this Nov 29, 2016

@abdonrd

This comment has been minimized.

Show comment
Hide comment
@abdonrd

abdonrd Nov 29, 2016

Nice! 🎉

abdonrd commented Nov 29, 2016

Nice! 🎉

@juliantoledo

This comment has been minimized.

Show comment
Hide comment
@juliantoledo

juliantoledo Nov 29, 2016

Collaborator

@x1ddos Great!!! I will update our server.

Collaborator

juliantoledo commented Nov 29, 2016

@x1ddos Great!!! I will update our server.

@x1ddos

This comment has been minimized.

Show comment
Hide comment
@x1ddos

x1ddos Nov 29, 2016

Collaborator

@juliantoledo I'll start the OSS process for moonlight.

Collaborator

x1ddos commented Nov 29, 2016

@juliantoledo I'll start the OSS process for moonlight.

@juliantoledo

This comment has been minimized.

Show comment
Hide comment
@juliantoledo

juliantoledo Dec 2, 2016

Collaborator

@x1ddos Thank you for your work on moonlight!

Deployed your new version to our server, it will take about 1 hour to score all PWAs again.

Collaborator

juliantoledo commented Dec 2, 2016

@x1ddos Thank you for your work on moonlight!

Deployed your new version to our server, it will take about 1 hour to score all PWAs again.

@abdonrd

This comment has been minimized.

Show comment
Hide comment

abdonrd commented Dec 2, 2016

Yay! Thanks @juliantoledo!

@abdonrd

This comment has been minimized.

Show comment
Hide comment
@abdonrd

abdonrd Dec 2, 2016

Why the differences in Gulliver and Lighthouse extension?

Gulliver: 91
https://pwa-directory.appspot.com/pwas/5761645611581440

Lighthouse extension: 97
screen shot 2016-12-02 at 12 20 51

abdonrd commented Dec 2, 2016

Why the differences in Gulliver and Lighthouse extension?

Gulliver: 91
https://pwa-directory.appspot.com/pwas/5761645611581440

Lighthouse extension: 97
screen shot 2016-12-02 at 12 20 51

@juliantoledo

This comment has been minimized.

Show comment
Hide comment
@juliantoledo

juliantoledo Dec 2, 2016

Collaborator

@abdonrd we use a version of Lighthouse built on Headless Chromium which enables it to run as a server app, for that reason our Lighthouse score and report may deviate from the standard Lighthouse Chrome extension. We are trying to get as close as possible, the major issue we had was the HTTPS detection, but we still need to look into other broken signals.

Collaborator

juliantoledo commented Dec 2, 2016

@abdonrd we use a version of Lighthouse built on Headless Chromium which enables it to run as a server app, for that reason our Lighthouse score and report may deviate from the standard Lighthouse Chrome extension. We are trying to get as close as possible, the major issue we had was the HTTPS detection, but we still need to look into other broken signals.

@adewale

This comment has been minimized.

Show comment
Hide comment
@adewale

adewale Dec 2, 2016

Please file bugs for any differences you find.

adewale commented Dec 2, 2016

Please file bugs for any differences you find.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment