Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Every other frame detects barcodes #130

Open
mmocny opened this issue Jun 13, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@mmocny
Copy link
Collaborator

commented Jun 13, 2019

I noticed while testing that every-other frame in passive mode accurately detects barcodes in camera feed. This happens very consistently, so it is not just that the camera is shaking and occasionally failing to detect the barcode.

Because we use timeouts, we do not see this effect in our UX, but it is thrashing state in ways that worries me.

@mmocny mmocny assigned mmocny and paullewis and unassigned mmocny Jun 13, 2019

@paullewis

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2019

I'm struggling to repro. If you up the value at https://github.com/GoogleChromeLabs/perception-toolkit/blob/master/src/elements/perception-toolkit/perception-toolkit.ts#L427 to something like 4000 do you see that it's better? For me in 'passive' mode it definitely drops the detection rate. Our 'burst' mode is one where it really thrashes... and actually that might just make the case for us to dip our passive rate from 400 to something more conservative like 750 or so.

@mmocny

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 13, 2019

I'll play with that value, maybe I was just on the cusp of barcode processing time or something with 400.

FWIW I was testing with demo/simple and directly on my Pixel 3 XL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.