Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Planar Image Tests failing on safari #133

Open
mmocny opened this issue Jun 14, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@mmocny
Copy link
Collaborator

commented Jun 14, 2019

createImageBitmap, as used here, is not defined on safari.

@mmocny

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 17, 2019

So, something unusual is up with planar image tests, and I'm having no luck resolving. Separate from the report in this bug, which Paul mentioned may just be due to Safari, I'm seeing an issue in Travis:

The refactor patch is failing travis CI tests, and I cannot repro locally.

Reading the test itself, I cannot really see how it could fail in this way. I.e., a fn which returns DetectedImage[], and a test which asserts length > 0, seems to have an invalid first element?!

I'm eagerly awaiting to see if PR #131 changes this issue as well...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.