Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meaning Maker tests are flaky due to rotating karma serving port number #135

Closed
mmocny opened this issue Jun 17, 2019 · 2 comments

Comments

Projects
None yet
2 participants
@mmocny
Copy link
Collaborator

commented Jun 17, 2019

Several MM tests rely on a fixed port number for karma tests (in order to test dynamic discovery via target URL).

Because the URL has to match exactly what is specified in the structured data, and because the structured data is currently hardcoded to a specific portNum (9876), but I'm sometimes getting karma served on other ports (e.g. 9877).

Ideally the test assets would be templated and supplied to domain:portNum value. However, could workaround the issue by implementing support for relative URLs, which we want anyway (#97).

I will disable these tests for now to stop the flake.

@paullewis

This comment has been minimized.

Copy link
Collaborator

commented Jun 18, 2019

sg. I think we want to go with #97 rather than making the test suite any more complicated.

@mmocny

This comment has been minimized.

Copy link
Collaborator Author

commented Jun 18, 2019

#136 already fixes the tests in a way that isn't complicated at all. It also improves the tests in the process.

@mmocny mmocny closed this in b30da51 Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.