Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename `markerchanges` event, now that we support non-markers #94

Closed
mmocny opened this issue Apr 29, 2019 · 3 comments

Comments

Projects
None yet
3 participants
@mmocny
Copy link
Collaborator

commented Apr 29, 2019

Now that we support Image targets alongside markers like barcode/qrcode (and, anticipating even more crazy target types in the future), we should set appropriate names for events fired from the toolkit.

Do we want separate events for each target type? Or one event for any result changes?

Today we use markerchanges, but that (a) fires for non-markers, and (b) only fires if we have artifact content results (doesn't fire for all markesr).

My suggestion: perceptiontoolkitresults

@mmocny

This comment has been minimized.

Copy link
Collaborator Author

commented Apr 29, 2019

...also, right now this event fires when some target is found, yet we don't have any results for it.

This ends up with found: [] and lost: [], which seems pretty useless.

We could:

  • Include unknown: [... raw Target value ]
  • Just don't fire for unknown. We already have events for target detection.
@jpmedley

This comment has been minimized.

Copy link
Collaborator

commented May 3, 2019

It's rarely necessary to the complete product name in a piece of a product since you can assume users will know that that information at the time they're using it. I would call it something like perceivedresults.

@mmocny

This comment has been minimized.

Copy link
Collaborator Author

commented May 3, 2019

Now that we use a global variable to store the actual string value, we could use:

PerceptionToolkit.Events.PerceivedResults = '...'

And possibly use the longer name for the actual value. I doubt anyone is using perceivedresults event name in the wild, but since we are firing on global, its needs to be globally unique name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.