Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more README cleanups, and contribution guidelines #108

Merged
merged 2 commits into from May 8, 2019

Conversation

Projects
None yet
2 participants
@smalls
Copy link
Collaborator

commented May 8, 2019

Part of #17

@smalls smalls requested a review from mmocny May 8, 2019

README.md Outdated
* Geolocation (native)
* (TODO) Planar Image
* Planar Image

This comment has been minimized.

Copy link
@mmocny

mmocny May 8, 2019

Collaborator

2D Images, maybe?

The description for Augmented Images for ARCore is: "Augmented Images in ARCore lets you build AR apps that can respond to 2D images in the user's environment, such as posters or product packaging."

We don't augment the image, so I wouldn't call it Augmented Images.

This comment has been minimized.

Copy link
@smalls

smalls May 8, 2019

Author Collaborator

Split the difference: * 2D (Planar) Images?

We've been using the "planar image" terminology pretty consistently, and that's what the code is under in third_party, so I think there's value in keeping it - while, at the same time, I think being consistent with ARCore is important, and I think more folks might know what 2D is as opposed to planar.

This comment has been minimized.

Copy link
@smalls

smalls May 8, 2019

Author Collaborator

(I'll merge this but happy to revisit)

@mmocny

mmocny approved these changes May 8, 2019

Copy link
Collaborator

left a comment

Good fixes, thanks. Just one nit.

@smalls smalls merged commit 7b75523 into GoogleChromeLabs:master May 8, 2019

1 check passed

cla/google All necessary CLAs are signed

@smalls smalls deleted the smalls:readme-updates branch May 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.