Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds reset; fixes multiple target issue. #127

Merged
merged 1 commit into from Jun 13, 2019

Conversation

Projects
None yet
2 participants
@paullewis
Copy link
Collaborator

commented Jun 13, 2019

Fixes #126

@mmocny

mmocny approved these changes Jun 13, 2019

@@ -21,7 +21,7 @@ import { Marker } from '../../../defs/marker.js';
import { DEBUG_LEVEL, log } from '../../utils/logger.js';

class Detector {
private readonly targets = new Map<number, DetectableImage>();
private readonly targets = new Map<number, { id: string }>();

This comment has been minimized.

Copy link
@mmocny

mmocny Jun 13, 2019

Collaborator

DetectedImage has this interface, if you want.

This comment has been minimized.

Copy link
@paullewis

paullewis Jun 13, 2019

Author Collaborator

We ping the whole thing over to the worker and back, which means we'd have to transfer the whole DetectableImage :-/

This comment has been minimized.

Copy link
@mmocny

mmocny Jun 13, 2019

Collaborator

I said Detec*ted*Image not Detec*table*Image ;)

The difference is the lack fo media:

This comment has been minimized.

Copy link
@paullewis

paullewis Jun 13, 2019

Author Collaborator

Oops

@paullewis paullewis merged commit a21f294 into master Jun 13, 2019

5 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.