Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #135: replace flaky MM test for dynamic markers with simple barcode test #136

Merged
merged 3 commits into from Jun 18, 2019

Conversation

Projects
None yet
2 participants
@mmocny
Copy link
Collaborator

commented Jun 17, 2019

Instead of disabling flaky tests, I simplified MM tests to not depend on URL-specific qr-codes as the marker value.

I also added a dynamic discovery test that actually tests dynamic URL loading -- but left if disabled for now, until I figure how out how to adjust to rotating port number (or implement relative URL paths).

mmocny added some commits Jun 18, 2019

@mmocny mmocny merged commit b30da51 into master Jun 18, 2019

5 checks passed

Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
cla/google All necessary CLAs are signed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mmocny mmocny deleted the disable_failing_mm_tests branch Jun 18, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.