Remove resolveId hook and load hook from asset-plugin#517
Remove resolveId hook and load hook from asset-plugin#517queq1890 wants to merge 1 commit intoGoogleChromeLabs:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
That's fair, although it's a pattern we use on other projects, and the code isn't doing any harm (it doesn't end up in a client bundle). I guess we should publish the asset plugin to npm. |
makes sense to me. Thank you for the quick response 😄 |
While walking through proxx's Rollup config, I found that id with
asset-url:prefix no longer exists.So I think we can remove
resolveIdhook andloadhook that used to deal with such ids.