Skip to content

Remove resolveId hook and load hook from asset-plugin#517

Closed
queq1890 wants to merge 1 commit intoGoogleChromeLabs:masterfrom
queq1890:master
Closed

Remove resolveId hook and load hook from asset-plugin#517
queq1890 wants to merge 1 commit intoGoogleChromeLabs:masterfrom
queq1890:master

Conversation

@queq1890
Copy link
Copy Markdown

While walking through proxx's Rollup config, I found that id with asset-url: prefix no longer exists.
So I think we can remove resolveId hook and load hook that used to deal with such ids.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@queq1890
Copy link
Copy Markdown
Author

@googlebot I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jakearchibald
Copy link
Copy Markdown
Contributor

That's fair, although it's a pattern we use on other projects, and the code isn't doing any harm (it doesn't end up in a client bundle). I guess we should publish the asset plugin to npm.

@queq1890
Copy link
Copy Markdown
Author

queq1890 commented Jul 16, 2020

@jakearchibald

it's a pattern we use on other projects, and the code isn't doing any harm (it doesn't end up in a client bundle)

makes sense to me. Thank you for the quick response 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants