Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone support #43

Open
kirstyburgoine opened this issue Nov 4, 2019 · 0 comments
Open

Timezone support #43

kirstyburgoine opened this issue Nov 4, 2019 · 0 comments

Comments

@kirstyburgoine
Copy link
Collaborator

@kirstyburgoine kirstyburgoine commented Nov 4, 2019

Description

Which feature is your enhancement request related to?
#35 but affects all sitemaps.

Describe the solution you'd like
Each sitemap needs to have a <lastmod> date listed on the sitemap's index. Current thinking on how to approach this is:

I think the index sitemap will list the buckets and each bucket is a cpt object so has its own post_modified_gmt which is when it was last updated with content, I don’t think it will get much more complex. That bit is missing currently, and then each bit of content registered with a sitemap provided will update its bucket

https://hmn.slack.com/archives/CNVN3ERGV/p1572873401010900

The timezone for each post currently being used on the posts sitemap is: 'lastmod' => mysql2date( DATE_W3C, $post->post_modified_gmt, false ),

Additional context
Needs some discussion as to whether honouring the get_option( 'timezone_string' ) and fallback using get_option( 'gmt_offset' ) is needed on the sitemap index, or is it overkill for the scope of this project

Acceptance Criteria

Add the relevant acceptance criteria here.

  • Display the last modified date on sitemap.xml for each sitemap listed
@kirstyburgoine kirstyburgoine added this to To do in Execution via automation Nov 4, 2019
@joemcgill joemcgill assigned joemcgill and unassigned joemcgill Nov 13, 2019
@mcshanea mcshanea moved this from To do to In progress in Execution Nov 13, 2019
@mcshanea mcshanea moved this from In progress to Reviewer approved in Execution Nov 13, 2019
@mcshanea mcshanea moved this from Reviewer approved to Icebox in Execution Nov 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Execution
  
Icebox
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.