This repository was archived by the owner on Nov 11, 2022. It is now read-only.
Use a retrying Dataflow Client for DataflowPipelineJob #489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Looks good. I'll wait for tests before merging. |
Contributor
|
Three out of four Travis CI builds passed, and the one that failed looked like it was a Maven Central infrastructure issue that led to a timeout. Nonetheless, since it was also the only piece of the test matrix using OpenJDK, I've restarted the test run rather than merge. |
Contributor
|
The test that failed previously has now passed, along with all Linux-based tests. The Mac OSX entry of the test matrix was already green. So this is good and I am merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beam already does this; this will make DataflowPipelineJob.cancel() non-flaky.