New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloudspanner reuse instance and database #1461
Cloudspanner reuse instance and database #1461
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
06b9a01
to
9bab7c1
Compare
CLAs look good, thanks! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
863d55d
to
284e8a2
Compare
CLAs look good, thanks! |
@@ -81,7 +81,6 @@ def _Create(self): | |||
_, _, retcode = cmd.Issue() | |||
if retcode != 0: | |||
logging.error('Create GCP Spanner instance failed.') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check error code. For example, if spanner instance specified and already exist.
cca2d49
to
80999b6
Compare
80999b6
to
8631095
Compare
Separate cloud spanner instnace lifecycle from perfkit resource lifecycle.