Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More stringent linting rules (and update linter) #417

Merged
merged 1 commit into from Nov 15, 2018
Merged

More stringent linting rules (and update linter) #417

merged 1 commit into from Nov 15, 2018

Conversation

markmandel
Copy link
Member

I noticed that the linter was allowing through some commenting rules that weren't very good, so removed the option that was allowing that to happen exclude-use-default, and then also updated the linter while I was in here to the latest version.

@markmandel
More stringent linting rules (and update linter)
422ff34 
I noticed that the linter was allowing through some commenting rules that
weren't very good, so removed the option that was allowing that to happen
`exclude-use-default`, and then also updated the linter while I was in here
to the latest version.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Nov 15, 2018
@markmandel markmandel added this to the 0.6.0 milestone Nov 15, 2018
cyriltovena
cyriltovena approved these changes Nov 15, 2018
View reviewed changes
Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a2058a25-2786-4980-80cf-c00c98ee1a5d

The following development artifacts have been built, and will exist for the next 30 days:

(experimental) To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/417/head:pr_417 && git checkout pr_417
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.6.0-422ff34

@markmandel markmandel merged commit 88adba4 into googleforgames:master Nov 15, 2018
@markmandel markmandel deleted the cleanup/linter branch November 15, 2018 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Milestone
0.6.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markmandel @agones-bot @cyriltovena