Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified logging of resource identifiers so that we can reliably get entire history of a resource in stack driver. #616

Merged
merged 2 commits into from Feb 25, 2019

Conversation

jkowalski
Copy link
Contributor

Well-known identifiers of resources types are defined in new logfields package.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 4a8eab40-a840-4ab3-a542-1269c28a4af3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 8e14a0a7-b085-48c8-93f9-2d87f41d453e

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/616/head:pr_616 && git checkout pr_616
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-4d4c46c

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall - awesome. Had a few questions, and a couple of small cleanup items.

obj := review.Request.Object
gsa := &v1alpha1.GameServerAllocation{}

err := json.Unmarshal(obj.Raw, gsa)
if err != nil {
c.logger.WithError(err).Error("error unmarchaslling json")
c.baseLogger.WithError(err).Error("error unmarchalling json")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
c.baseLogger.WithError(err).Error("error unmarchalling json")
c.baseLogger.WithError(err).Error("error unmarshalling json")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -17,6 +17,8 @@ package gameservers
import (
"strings"

"agones.dev/agones/pkg/util/logfields"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: delete line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

errors.Wrap(err, "error retrieving GameServer owner"))
}
return
}
c.workerqueue.EnqueueImmediately(gsSet)
}

func loggerForGameServerSetKey(base *logrus.Entry, key string) *logrus.Entry {
return base.WithField(gameServerSetKeyFieldName, key)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not use logfields.GameServerSetKey ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@@ -21,6 +21,8 @@ import (
"sync"
"time"

"agones.dev/agones/pkg/util/logfields"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: empty line

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

pkg/util/workerqueue/workerqueue.go Show resolved Hide resolved
pkg/fleetautoscalers/controller.go Show resolved Hide resolved
pkg/gameservers/controller.go Show resolved Hide resolved
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 22, 2019
…n entire history of a resource in stack driver.

Well-known identifiers of resources types are defined in logfields package.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 21b80715-7cab-4184-8cb7-272f68fcc057

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/616/head:pr_616 && git checkout pr_616
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-0cff425

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 544d6b8c-3ce8-4c0f-a7cb-5b71caa9b9dd

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/616/head:pr_616 && git checkout pr_616
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-31fa9d2

Copy link
Member

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔔

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a9b24bc3-f9f9-41c4-9115-1adc2fcdf298

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/616/head:pr_616 && git checkout pr_616
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-b4b6f4b

@markmandel markmandel merged commit cb073a9 into googleforgames:master Feb 25, 2019
@markmandel markmandel added this to the 0.9.0 milestone Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Refactoring code, fixing up documentation, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants