Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Url pointing to install.yaml pointing to master #648

Closed
wants to merge 4 commits into from

Conversation

mathieuduperre
Copy link
Contributor

url was pointing to 0.7.0 install.yaml which was not the latest.

url was pointing to 0.7.0 install.yaml which was not the latest.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: a546b86b-8fcc-4f82-ad4e-a496d22896e1

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/648/head:pr_648 && git checkout pr_648
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-86018c6

@markmandel
Copy link
Member

Gentle bump on this - if you aren't going to be able to complete this @mathieuduperre , do you mind if someone takes this PR over?

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

Copy link
Contributor Author

@mathieuduperre mathieuduperre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lookds good

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: fd15ce46-44b7-448a-8910-d94baf38b484

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/648/head:pr_648 && git checkout pr_648
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-4d1b85c

updated the ref url to download the yaml

Co-Authored-By: mathieuduperre <mathieu.duperre@gmail.com>
@mathieuduperre
Copy link
Contributor Author

thx to GDC, multitasking is not working well.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: ee4e0e9d-514b-4a84-91e5-b7fd90cbc1a5

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/648/head:pr_648 && git checkout pr_648
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-ea85ac5

@markmandel
Copy link
Member

Hah! Tell me about it.

Can you also squash this into a single commit, and I'll happily approve this 👍

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 48fc40de-4f7a-436c-bb6b-54c246303ca0

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@markmandel markmandel added kind/bug These are bugs. kind/documentation Documentation for Agones feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) and removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Mar 26, 2019
@markmandel
Copy link
Member

Gently bumping this once more - if you don't have time for this, totally cool. Happy to take it over - just want to have this correct in the documentation 👍

@mathieuduperre
Copy link
Contributor Author

feel free to take over, I don't have the project on my laptop to squash it and it may be a while until I find times to dig this. thanks and my apology.

@markmandel
Copy link
Member

No worries at all! Life happens. I always like to ask permission before taking over PRs! Will jump on it.

markmandel pushed a commit to markmandel/agones that referenced this pull request Mar 28, 2019
url was pointing to 0.7.0 install.yaml which was not the latest.

Original PR: googleforgames#648

Co-Authored-By: mathieuduperre <mathieu.duperre@gmail.com>
@markmandel
Copy link
Member

Closing and opening a new PR!

@markmandel markmandel closed this Mar 28, 2019
markmandel pushed a commit that referenced this pull request Mar 28, 2019
url was pointing to 0.7.0 install.yaml which was not the latest.

Original PR: #648

Co-Authored-By: mathieuduperre <mathieu.duperre@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug These are bugs. kind/documentation Documentation for Agones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants